Feat/configurable page heights #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed fixed height to min-height in editor.html - Removed overflow:hidden to enable scrolling - Updated sidebar and demosidebar to use min-height with max-height - Pages now expand based on content and scroll naturally
…exibility - Changed editor page heights from fixed to flexible (min-height) - Removed overflow:hidden to enable scrolling - Moved "I'm Done" button from fixed position to below right sidebar - Button now scales with page zoom and stays aligned with sidebar - Updated sidebar heights to use min-height with max-height constraints
monicaz010101
requested review from
Copilot and
kcarnold
and removed request for
Copilot
Contributor
|
This PR should have a Playwright test that shows the problem it's solving, and a screenshot that shows that it's fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.