Skip to content

Sanitize RichText HTML with DOMPurify to prevent XSS #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sanitize RichText HTML with DOMPurify to prevent XSS #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/security/229-richtext-xss.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
Title: general-editor RichText XSS sanitization

Summary

- Address XSS risk in `general-editor` RichText rendering by sanitizing untrusted HTML prior to rendering.
- Applies sanitization before `dangerouslySetInnerHTML` and `iframe srcDoc` usage.

Details

- Affected area: `general-editor/src/tags/object/RichText/view.js`
- Mitigation: Use DOMPurify to sanitize the rendered HTML string.
- Dependency: `dompurify` declared in `general-editor/package.json`.

PoC (neutralized post-fix)

- `<img src=x onerror=alert('XSS')>`
- `<svg onload=alert('XSS')>`

Tracking

- Related issue: #229