Skip to content

fix(backtest): guard gamma impact param#41

Merged
AKKI0511 merged 1 commit intoadd-market-impact-model-featurefrom
comment-on-impact-model-parameter-handling
Aug 31, 2025
Merged

fix(backtest): guard gamma impact param#41
AKKI0511 merged 1 commit intoadd-market-impact-model-featurefrom
comment-on-impact-model-parameter-handling

Conversation

@AKKI0511
Copy link
Owner

Summary

  • avoid passing gamma=None to market impact models that don't accept it
  • test that gamma defaults do not break linear/square-root impact

Testing

  • poetry run pre-commit run --all-files

https://chatgpt.com/codex/tasks/task_e_68b3998bb428832aa2dd8e950765272c

@AKKI0511 AKKI0511 merged commit 33e8686 into add-market-impact-model-feature Aug 31, 2025
1 check passed
@AKKI0511 AKKI0511 deleted the comment-on-impact-model-parameter-handling branch August 31, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant