Skip to content

Implemented tridiag_solve for cubic spline#28

Merged
pasabanov merged 4 commits intomainfrom
cubic_spline
Feb 9, 2025
Merged

Implemented tridiag_solve for cubic spline#28
pasabanov merged 4 commits intomainfrom
cubic_spline

Conversation

@pasabanov
Copy link
Copy Markdown
Member

@pasabanov pasabanov commented Feb 9, 2025

Types of changes

  • Feature
  • Documentation
  • Refactoring, reformatting, cleanup
  • Licensing

Related: #7 ALFI-lib/alfi-lib.github.io/pull/3 ALFI-lib/alfi-lib.github.io/pull/8

Description

  1. Refactor:

    • Removed merge_coeffs function and replaced it with a loop.
    • Changed type for dX and dY from const Container<Number> to const auto.
  2. Feature:

    • Added tridiag_solve_unstable function for use in cases where stability conditions are satisfied.
    • Added tridiag_solve function based on Add not-a-knot boundary conditions snsinfu/cxx-spline#2.
    • The function tridiag_solve is now used to compute coefficients for all splines, except for "Periodic", "Not-a-knot-start", "Not-a-knot-end" and "Semi-not-a-knot".
      It is used directly in "Not-a-knot", "Clamped", "Fixed-second" and "Fixed-third" and indirectly in "Natural" and "Parabolic-ends".
  3. Documentation:

    • Added documentation for tridiag_solve_unstable and tridiag_solve.
  4. Licensing:

    • Due to @snsinfu's code being under the BSL-1.0 license I had to place it somewhere in the repository. I put it in licenses/BSL-1.0 and added new file LICENSE where the temporary "default copyright law" license is stated for clarity.

@pasabanov pasabanov added chore Refactoring, formatting, cleanup docs Improvements or additions to documentation feature New feature or request labels Feb 9, 2025
@pasabanov pasabanov added this to the First Release Version milestone Feb 9, 2025
@pasabanov pasabanov self-assigned this Feb 9, 2025
@pasabanov pasabanov force-pushed the cubic_spline branch 4 times, most recently from 3da8382 to fb51b66 Compare February 9, 2025 15:47
@pasabanov pasabanov merged commit 060b933 into main Feb 9, 2025
5 checks passed
@pasabanov pasabanov deleted the cubic_spline branch February 9, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Refactoring, formatting, cleanup docs Improvements or additions to documentation feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant