quadratic.h: added std::move in constructors#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Related: #30
Description
Added
std::movein constructors inquadratic.hfor consistency with other files (step.h,cubic.h).In addition to moving the
Numbervariables, theSizeTvariables were also moved.The move can be removed for
SizeT, since it is trivially copyable by default, but it can be changed by user; alsostd::moveindicated a logical move, even if the value is in fact copied.Clang-Tidy warns about using
std::moveon trivially copyable type: https://clang.llvm.org/extra/clang-tidy/checks/performance/move-const-arg.html.It is recommended to configure this check by turning off the
CheckTriviallyCopyableMoveoption.In CLion this can be achieved by turning off
hicpp-move-const-arg.CheckTriviallyCopyableMoveandperformance-move-const-arg.CheckTriviallyCopyableMoveoptions.