Conversation
pasabanov
force-pushed
the
ci
branch
2 times, most recently
from
a70bbbf to
18f4632
Compare
Clang-Tidy started failing due to the `-Wno-lto-type-mismatch` and `-s` options for the Google Benchmark object files. This is strange, as it didn't fail right after the benchmarks were implemented, and they haven't been changed since, especially considering Clang-Tidy should ignore the source files for these object files. This commit adds the `-Wno-unknown-warning-option` and `-Wno-unused-command-line-argument` options to Clang-Tidy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Related: #46 #58
Description
Clang-Tidy started failing due to the
-Wno-lto-type-mismatchand-soptions for the Google Benchmark object files.This is strange, as it didn't fail right after the benchmarks were implemented, and they haven't been changed since, especially especially considering Clang-Tidy should ignore the source files for these object files.
This commit adds the
-Wno-unknown-warning-optionand-Wno-unused-command-line-argumentoptions to Clang-Tidy.Additional information
logs_36137402605.zip
PolyEqvSpline#63)):logs_36402007344.zip
logs_36439522113.zip