Skip to content

PEtab parameter mapping: minor speedup#2640

Merged
dweindl merged 1 commit intoAMICI-dev:developfrom
dweindl:par_map
Feb 6, 2025
Merged

PEtab parameter mapping: minor speedup#2640
dweindl merged 1 commit intoAMICI-dev:developfrom
dweindl:par_map

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jan 30, 2025

Avoid repeated lookups. Saves just a few seconds for Froehlich_CellSystems2018, but better than nothing...

Avoid repeated lookups. Saves just a few seconds for Froehlich_CellSystems2018, but better than nothing...
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (923b8f4) to head (d0ce54b).
Report is 67 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2640      +/-   ##
===========================================
- Coverage    77.06%   77.04%   -0.03%     
===========================================
  Files          332      332              
  Lines        22972    22974       +2     
  Branches      1478     1478              
===========================================
- Hits         17704    17700       -4     
- Misses        5257     5263       +6     
  Partials        11       11              
Flag Coverage Δ
cpp 74.43% <16.66%> (-0.10%) ⬇️
cpp_python 33.98% <16.66%> (+0.07%) ⬆️
petab 38.88% <100.00%> (+0.01%) ⬆️
python 72.42% <66.66%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/conditions.py 96.29% <100.00%> (+0.80%) ⬆️
python/sdist/amici/petab/util.py 80.95% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review February 5, 2025 22:55
@dweindl dweindl requested a review from a team as a code owner February 5, 2025 22:55
@dweindl dweindl added this pull request to the merge queue Feb 5, 2025
Merged via the queue into AMICI-dev:develop with commit 65f2ab7 Feb 6, 2025
20 checks passed
@dweindl dweindl deleted the par_map branch February 27, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants