Skip to content

Conversation

@FFroehlich
Copy link
Member

Summary

  • add a cron-based GitHub Actions workflow to verify conda installations on Linux and macOS
  • ensure the workflow also runs on pull requests

Testing

  • pre-commit run --files .github/workflows/test_conda_install.yml
  • pytest tests/benchmark_models/test_petab_benchmark.py -k Boehm_JProteomeRes2014
  • pytest tests/benchmark_models/test_petab_benchmark_jax.py -k Boehm_JProteomeRes2014

https://chatgpt.com/codex/tasks/task_b_685d2741a818832ba131032a356886d8

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.39%. Comparing base (319efac) to head (6a43cb9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2839      +/-   ##
==========================================
- Coverage   78.03%   77.39%   -0.64%     
==========================================
  Files         311      311              
  Lines       20584    20584              
  Branches     1499     1499              
==========================================
- Hits        16063    15932     -131     
- Misses       4511     4642     +131     
  Partials       10       10              
Flag Coverage Δ
cpp 70.32% <ø> (ø)
cpp_python 36.74% <ø> (ø)
petab 45.71% <ø> (ø)
petab_sciml 13.65% <ø> (ø)
python 69.33% <ø> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2025

@dweindl dweindl linked an issue Jul 17, 2025 that may be closed by this pull request
@dweindl dweindl force-pushed the 92qzwt-codex/add-cron-run-github-action-for-amici-installation branch from daec16c to 98a5490 Compare October 20, 2025 08:51
@FFroehlich FFroehlich requested a review from a team as a code owner November 7, 2025 09:42
@FFroehlich FFroehlich self-assigned this Nov 7, 2025
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Finally 😅

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@dweindl dweindl merged commit d20f97b into main Nov 12, 2025
29 of 31 checks passed
@dweindl dweindl deleted the 92qzwt-codex/add-cron-run-github-action-for-amici-installation branch November 12, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for installing amici under conda

3 participants