Enable pickling of ModelPtr
#2985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2985 +/- ##
==========================================
- Coverage 76.48% 75.83% -0.66%
==========================================
Files 308 308
Lines 20136 20149 +13
Branches 1499 1500 +1
==========================================
- Hits 15402 15280 -122
- Misses 4721 4856 +135
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Enable pickling of `ModelPtr` for use in multiprocessing contexts.
dweindl
force-pushed
the
pickle_modelptr
branch
from
d959294 to
624b4b3
Compare
FFroehlich
approved these changes
Oct 23, 2025
| model_module = sbml_example_presimulation_module | ||
| model = model_module.get_model() | ||
|
|
||
| assert ( |
Member
There was a problem hiding this comment.
we are already testing other settings programmatically in corresponding tests for get_model_settings, right?
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Oct 27, 2025
Ensure `Model.module` gets set during `Model.clone()`. So far, this was only set during `model_module.get_model`. Fixes unpickling of cloned Models. Also implement `ModelPtr.__reduce__` in addition to `Model.__reduce__` (AMICI-dev#2985).
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Oct 27, 2025
Ensure `Model.module` gets set during `Model.clone()`. So far, this was only set during `model_module.get_model`. Fixes unpickling of cloned Models. Also implement `ModelPtr.__reduce__` in addition to `Model.__reduce__` (AMICI-dev#2985).
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Oct 29, 2025
Ensure `Model.module` gets set during `Model.clone()`. So far, this was only set during `model_module.get_model`. Fixes unpickling of cloned Models. Also implement `ModelPtr.__reduce__` in addition to `Model.__reduce__` (AMICI-dev#2985).
dweindl
added a commit
that referenced
this pull request
Oct 29, 2025
Ensure `Model.module` gets set during `Model.clone()`. So far, this was only set during `model_module.get_model`. Fixes unpickling of cloned Models. Also implement `ModelPtr.__reduce__` in addition to `Model.__reduce__` (#2985).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pickling of
ModelPtrfor use in multiprocessing contexts.Related to #1126.