Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 30, 2025

Previously, Model settings were used, independently of whether ExpData had different settings.

@dweindl dweindl self-assigned this Oct 30, 2025
@dweindl dweindl force-pushed the grad_check_edata_parameters branch 2 times, most recently from dd94adf to 29e4b37 Compare October 30, 2025 16:19
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.80%. Comparing base (25adebf) to head (ec6c1af).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2995      +/-   ##
==========================================
- Coverage   76.48%   75.80%   -0.69%     
==========================================
  Files         308      308              
  Lines       19540    19546       +6     
  Branches     1500     1500              
==========================================
- Hits        14945    14816     -129     
- Misses       4582     4717     +135     
  Partials       13       13              
Flag Coverage Δ
cpp 72.89% <92.85%> (+<0.01%) ⬆️
cpp_python 38.25% <57.14%> (-0.01%) ⬇️
petab 38.86% <78.57%> (-0.01%) ⬇️
python 69.62% <92.85%> (+<0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/gradient_check.py 95.68% <100.00%> (+0.23%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the grad_check_edata_parameters branch from 29e4b37 to 0af7154 Compare October 30, 2025 17:58
Previously, Model settings were used, independently of whether ExpData had different settings.
@dweindl dweindl force-pushed the grad_check_edata_parameters branch from 0af7154 to ec6c1af Compare October 30, 2025 18:07
@dweindl dweindl marked this pull request as ready for review October 30, 2025 21:26
@dweindl dweindl requested a review from a team as a code owner October 30, 2025 21:26
@dweindl dweindl added this pull request to the merge queue Oct 31, 2025
Merged via the queue into AMICI-dev:main with commit 1e006bb Oct 31, 2025
17 of 18 checks passed
@dweindl dweindl deleted the grad_check_edata_parameters branch October 31, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants