Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 1, 2025

Store swig version used for the amici and model extensions. Emit a warning if versions don't match.

Closes #2993.

Store swig version used for the amici and model extensions.
Emit a warning if versions don't match.

Closes AMICI-dev#2993.
@dweindl dweindl self-assigned this Nov 1, 2025
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.05%. Comparing base (4360d5e) to head (93683c0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3000      +/-   ##
==========================================
- Coverage   76.73%   76.05%   -0.68%     
==========================================
  Files         309      309              
  Lines       19884    19884              
  Branches     1498     1498              
==========================================
- Hits        15258    15123     -135     
- Misses       4613     4748     +135     
  Partials       13       13              
Flag Coverage Δ
cpp 72.55% <ø> (ø)
cpp_python 37.72% <ø> (ø)
petab 38.59% <ø> (ø)
petab_sciml 14.15% <ø> (ø)
python 69.37% <ø> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review November 1, 2025 11:28
@dweindl dweindl requested a review from a team as a code owner November 1, 2025 11:28
@dweindl dweindl added this pull request to the merge queue Nov 1, 2025
Merged via the queue into AMICI-dev:main with commit 7f8bc18 Nov 1, 2025
18 of 19 checks passed
@dweindl dweindl deleted the gh-2993-swig-version-check branch November 1, 2025 14:23
dweindl added a commit that referenced this pull request Nov 3, 2025
Store swig version used for the amici and model extensions.
Emit a warning if versions don't match.

Closes #2993.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

swig version requirements

2 participants