Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 1, 2025

Currently, there are several places where default model directory paths are generated. Centralize that.

Running the test suite or building the documentation creates model directories all over the place. Reduce that.

Allow overriding the model base dir via environment variable.

Having version-specific subdirectories circumvents import issues with models from different amici versions.

Closes #2994.

@dweindl dweindl self-assigned this Nov 1, 2025
Currently, there are several places where default model directory paths are generated. Centralize that.

Running the test suite or building the documentation creates model directories all over the place. Reduce that.

Allow overriding the model base dir via environment variable.

Closes AMICI-dev#2994.
@dweindl dweindl force-pushed the gh-2994-model-dirs branch from 41e48db to 8c3fe3e Compare November 1, 2025 14:42
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.04%. Comparing base (cb1f08e) to head (8c3fe3e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/__init__.py 91.66% 1 Missing ⚠️
python/sdist/amici/de_export.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
- Coverage   76.65%   76.04%   -0.61%     
==========================================
  Files         309      309              
  Lines       19891    19898       +7     
  Branches     1498     1498              
==========================================
- Hits        15248    15132     -116     
- Misses       4630     4753     +123     
  Partials       13       13              
Flag Coverage Δ
cpp 72.53% <73.33%> (+0.05%) ⬆️
cpp_python 37.71% <26.66%> (+<0.01%) ⬆️
petab 38.61% <88.88%> (+0.03%) ⬆️
petab_sciml 14.14% <13.33%> (+<0.01%) ⬆️
python 69.36% <86.66%> (+0.06%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/petab_import.py 100.00% <ø> (ø)
python/sdist/amici/petab/sbml_import.py 75.21% <ø> (+0.61%) ⬆️
python/sdist/amici/pysb_import.py 94.49% <100.00%> (+0.01%) ⬆️
python/sdist/amici/sbml_import.py 81.47% <100.00%> (-12.49%) ⬇️
python/tests/conftest.py 43.33% <100.00%> (+4.04%) ⬆️
python/sdist/amici/__init__.py 95.23% <91.66%> (-0.85%) ⬇️
python/sdist/amici/de_export.py 96.89% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review November 1, 2025 18:33
@dweindl dweindl requested a review from a team as a code owner November 1, 2025 18:33
@dweindl dweindl added this pull request to the merge queue Nov 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2025
@dweindl dweindl added this pull request to the merge queue Nov 1, 2025
Merged via the queue into AMICI-dev:main with commit b78b3bf Nov 1, 2025
24 of 25 checks passed
@dweindl dweindl deleted the gh-2994-model-dirs branch November 2, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harmonize model output directories

2 participants