Centralize default model path generation#3002
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Nov 1, 2025
Merged
Conversation
Currently, there are several places where default model directory paths are generated. Centralize that. Running the test suite or building the documentation creates model directories all over the place. Reduce that. Allow overriding the model base dir via environment variable. Closes AMICI-dev#2994.
dweindl
force-pushed
the
gh-2994-model-dirs
branch
from
41e48db to
8c3fe3e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
==========================================
- Coverage 76.65% 76.04% -0.61%
==========================================
Files 309 309
Lines 19891 19898 +7
Branches 1498 1498
==========================================
- Hits 15248 15132 -116
- Misses 4630 4753 +123
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Nov 1, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are several places where default model directory paths are generated. Centralize that.
Running the test suite or building the documentation creates model directories all over the place. Reduce that.
Allow overriding the model base dir via environment variable.
Having version-specific subdirectories circumvents import issues with models from different amici versions.
Closes #2994.