Skip to content

Conversation

@FFroehlich
Copy link
Member

No description provided.

@FFroehlich FFroehlich requested a review from a team as a code owner November 1, 2025 21:32
@FFroehlich FFroehlich marked this pull request as draft November 1, 2025 21:33
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.04%. Comparing base (de6c323) to head (21f200b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3005      +/-   ##
==========================================
- Coverage   76.71%   76.04%   -0.68%     
==========================================
  Files         309      309              
  Lines       19900    19900              
  Branches     1497     1497              
==========================================
- Hits        15267    15132     -135     
- Misses       4620     4755     +135     
  Partials       13       13              
Flag Coverage Δ
cpp 72.49% <ø> (ø)
cpp_python 37.91% <ø> (ø)
petab 38.53% <ø> (ø)
petab_sciml 14.15% <ø> (ø)
python 69.32% <ø> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_model.py 92.12% <ø> (-0.39%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FFroehlich FFroehlich marked this pull request as ready for review November 2, 2025 10:03
@FFroehlich FFroehlich requested review from a team and removed request for a team November 2, 2025 10:16
@FFroehlich FFroehlich enabled auto-merge November 2, 2025 10:26
@dweindl
Copy link
Member

dweindl commented Nov 2, 2025

Due to the updated required status checks for py3.14, this branch needs to be updated after #2976 is merged to enter the merge queue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2025

@FFroehlich FFroehlich added this pull request to the merge queue Nov 2, 2025
Merged via the queue into main with commit cf9d349 Nov 2, 2025
27 of 28 checks passed
dweindl added a commit to dweindl/AMICI that referenced this pull request Nov 4, 2025
Replace the remaining usages of `strip_pysb` after AMICI-dev#3005.

Some were useless anyways.

Closes AMICI-dev#3004.
@dweindl dweindl mentioned this pull request Nov 4, 2025
dweindl added a commit to dweindl/AMICI that referenced this pull request Nov 4, 2025
Replace the remaining usages of `strip_pysb` after AMICI-dev#3005.

Some were useless anyways.

Closes AMICI-dev#3004.
dweindl added a commit that referenced this pull request Nov 5, 2025
Replace the remaining usages of `strip_pysb` after #3005.

Some were useless anyways.

Closes #3004.
@dweindl dweindl deleted the strip_pysb branch November 10, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants