Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 10, 2025

Convert remaining function names to snake-case. Closes #887.

@dweindl dweindl self-assigned this Nov 10, 2025
@dweindl dweindl requested a review from a team as a code owner November 10, 2025 08:48
Convert remaining function names to snake-case. Closes AMICI-dev#887.
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.03%. Comparing base (7f15329) to head (6712ff8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/edata.cpp 76.92% 3 Missing ⚠️
src/model_dae.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3017      +/-   ##
==========================================
- Coverage   76.71%   76.03%   -0.68%     
==========================================
  Files         309      309              
  Lines       19899    19899              
  Branches     1497     1497              
==========================================
- Hits        15265    15130     -135     
- Misses       4621     4756     +135     
  Partials       13       13              
Flag Coverage Δ
cpp 72.49% <94.11%> (ø)
cpp_python 37.89% <29.41%> (ø)
petab 38.52% <24.61%> (ø)
petab_sciml 14.15% <0.00%> (ø)
python 69.31% <94.11%> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/abstract_model.h 100.00% <ø> (ø)
include/amici/edata.h 100.00% <ø> (ø)
include/amici/model_dae.h 80.00% <ø> (ø)
include/amici/model_ode.h 100.00% <ø> (ø)
include/amici/rdata.h 100.00% <ø> (ø)
src/hdf5.cpp 66.74% <100.00%> (ø)
src/model.cpp 85.64% <100.00%> (ø)
src/model_ode.cpp 67.25% <100.00%> (ø)
src/rdata.cpp 81.65% <100.00%> (ø)
src/solver.cpp 79.68% <100.00%> (ø)
... and 2 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl merged commit 2204711 into AMICI-dev:main Nov 10, 2025
20 of 22 checks passed
@dweindl dweindl deleted the refactor_snake branch November 10, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coherent style

2 participants