Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 10, 2025

For spline handling, replace mathml2sympy by sbmlmath functions. Related to #2146.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.38%. Comparing base (84b9d8d) to head (5bc059a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/exporters/sundials/de_export.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3020      +/-   ##
==========================================
- Coverage   78.02%   77.38%   -0.65%     
==========================================
  Files         311      311              
  Lines       20598    20584      -14     
  Branches     1499     1500       +1     
==========================================
- Hits        16071    15928     -143     
- Misses       4517     4646     +129     
  Partials       10       10              
Flag Coverage Δ
cpp 70.30% <14.28%> (-0.03%) ⬇️
cpp_python 36.74% <85.71%> (-0.04%) ⬇️
petab 45.71% <0.00%> (+0.02%) ⬆️
petab_sciml 13.65% <0.00%> (-0.01%) ⬇️
python 69.32% <85.71%> (-0.02%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 82.20% <ø> (-12.08%) ⬇️
python/sdist/amici/sbml_utils.py 80.57% <ø> (-0.84%) ⬇️
python/sdist/amici/splines.py 80.59% <100.00%> (+0.03%) ⬆️
python/sdist/amici/exporters/sundials/de_export.py 96.91% <83.33%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
Copy link
Member Author

dweindl commented Nov 10, 2025

FIXME: codeprinter: print all sympy.Integers as floats.

@dweindl dweindl self-assigned this Nov 10, 2025
@dweindl dweindl force-pushed the remove_mathml2sympy branch from 92f6c25 to 555b300 Compare November 11, 2025 07:23
@dweindl dweindl marked this pull request as ready for review November 11, 2025 07:58
@dweindl dweindl requested a review from a team as a code owner November 11, 2025 07:58
@dweindl dweindl added this pull request to the merge queue Nov 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2025
@dweindl dweindl force-pushed the remove_mathml2sympy branch from 555b300 to e8e7d83 Compare November 11, 2025 10:50
@dweindl dweindl added this pull request to the merge queue Nov 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2025
For spline handling, replace `mathml2sympy` by sbmlmath functions.
Related to AMICI-dev#2146.

Also fix potential code printing issues resulting in unintended integer division specifically for splines.
@dweindl dweindl force-pushed the remove_mathml2sympy branch from e8e7d83 to 5bc059a Compare November 11, 2025 13:40
@dweindl dweindl added this pull request to the merge queue Nov 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2025
@dweindl dweindl merged commit 1e8cf9c into AMICI-dev:main Nov 11, 2025
25 of 26 checks passed
@dweindl dweindl deleted the remove_mathml2sympy branch November 11, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants