Skip to content

Harmonize Fixed parameter Names#3027

Merged
dweindl merged 24 commits intomainfrom
fixed_parameters
Nov 14, 2025
Merged

Harmonize Fixed parameter Names#3027
dweindl merged 24 commits intomainfrom
fixed_parameters

Conversation

@FFroehlich
Copy link
Member

@FFroehlich FFroehlich commented Nov 12, 2025

fixes #975

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 76.99115% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.39%. Comparing base (e75c348) to head (df0b1b8).
⚠️ Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
src/model.cpp 80.76% 10 Missing ⚠️
python/sdist/amici/adapters/fiddy.py 72.72% 3 Missing ⚠️
src/backwardproblem.cpp 0.00% 3 Missing ⚠️
models/model_calvetti_py/main.cpp 0.00% 2 Missing ⚠️
models/model_dirac_py/main.cpp 0.00% 2 Missing ⚠️
models/model_events_py/main.cpp 0.00% 2 Missing ⚠️
models/model_jakstat_adjoint_py/main.cpp 0.00% 2 Missing ⚠️
models/model_nested_events_py/main.cpp 0.00% 2 Missing ⚠️
models/model_neuron_py/main.cpp 0.00% 2 Missing ⚠️
models/model_robertson_py/main.cpp 0.00% 2 Missing ⚠️
... and 18 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3027      +/-   ##
==========================================
- Coverage   78.04%   77.39%   -0.66%     
==========================================
  Files         311      311              
  Lines       20590    20594       +4     
  Branches     1499     1499              
==========================================
- Hits        16069    15938     -131     
- Misses       4511     4646     +135     
  Partials       10       10              
Flag Coverage Δ
cpp 70.32% <72.27%> (-0.02%) ⬇️
cpp_python 36.75% <27.72%> (-0.01%) ⬇️
petab 45.73% <47.09%> (+<0.01%) ⬆️
petab_sciml 13.66% <10.59%> (-0.01%) ⬇️
python 69.33% <70.90%> (-0.01%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/edata.h 100.00% <ø> (ø)
include/amici/model.h 78.04% <ø> (ø)
include/amici/serialization.h 95.17% <100.00%> (ø)
include/amici/simulation_parameters.h 100.00% <100.00%> (ø)
include/amici/solver_cvodes.h 100.00% <100.00%> (ø)
python/sdist/amici/constants.py 100.00% <100.00%> (ø)
python/sdist/amici/de_model.py 92.12% <100.00%> (-0.39%) ⬇️
python/sdist/amici/de_model_components.py 91.37% <100.00%> (-1.73%) ⬇️
python/sdist/amici/exporters/sundials/de_export.py 96.91% <ø> (ø)
python/sdist/amici/gradient_check.py 95.68% <100.00%> (ø)
... and 44 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FFroehlich FFroehlich changed the title Fixed parameters Harmonize Fixed parameter Names Nov 12, 2025
@dweindl
Copy link
Member

dweindl commented Nov 14, 2025

Notebook tests Ubuntu (3.11) fails due to the unfortunate pypesto dependency. Will update pypesto after this is merged.

We may want to consider moving that spline-parameter-estimation example to pypesto and just referencing it here.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@FFroehlich FFroehlich marked this pull request as ready for review November 14, 2025 11:18
@FFroehlich FFroehlich requested a review from a team as a code owner November 14, 2025 11:18
@FFroehlich FFroehlich enabled auto-merge November 14, 2025 11:19
@FFroehlich FFroehlich added this pull request to the merge queue Nov 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2025
@dweindl dweindl added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit 7bf3b76 Nov 14, 2025
32 of 35 checks passed
@FFroehlich FFroehlich deleted the fixed_parameters branch November 14, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harmonize Constant/FixedParameter/ConstantParameter

2 participants