Faster substitutions with smart_subs_dict II
#3030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
==========================================
- Coverage 78.03% 77.38% -0.66%
==========================================
Files 311 311
Lines 20587 20590 +3
Branches 1499 1499
==========================================
- Hits 16066 15934 -132
- Misses 4511 4646 +135
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Flatten out expressions first to avoid expensive repeated substitutions in matrices. For my current benchmark, this yields another 10x improvement compared to AMICI-dev#3025.
dweindl
force-pushed
the
faster_subs2
branch
from
749813a to
b2c3119
Compare
FFroehlich
approved these changes
Nov 13, 2025
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 17, 2025
Unfortunately, AMICI-dev#3030 doubled the import time for our performance test model, but the check there was too lax to catch it. Sometimes, `smart_subs_dict` is applied to individual expressions, sometimes to complete matrices. If it's only applied to individual expressions or small matrices, avoid the overhead of flattening the substitutions first. Update the time limits for the performance tests to catch such regressions earlier. Fixes AMICI-dev#3048.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 17, 2025
Unfortunately, AMICI-dev#3030 doubled the import time for our performance test model, but the check there was too lax to catch it. Sometimes, `smart_subs_dict` is applied to individual expressions, sometimes to complete matrices. If it's only applied to individual expressions or small matrices, avoid the overhead of flattening the substitutions first. Update the time limits for the performance tests to catch such regressions earlier. Fixes AMICI-dev#3048.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 18, 2025
Unfortunately, AMICI-dev#3030 doubled the import time for our performance test model, but the check there was too lax to catch it. Sometimes, `smart_subs_dict` is applied to individual expressions, sometimes to complete matrices. If it's only applied to individual expressions or small matrices, avoid the overhead of flattening the substitutions first. Update the time limits for the performance tests to catch such regressions earlier. Fixes AMICI-dev#3048.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 18, 2025
Unfortunately, AMICI-dev#3030 doubled the import time for our performance test model, but the check there was too lax to catch it. Sometimes, `smart_subs_dict` is applied to individual expressions, sometimes to complete matrices. If it's only applied to individual expressions or small matrices, avoid the overhead of flattening the substitutions first. Update the time limits for the performance tests to catch such regressions earlier. Fixes AMICI-dev#3048.
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 18, 2025
Unfortunately, AMICI-dev#3030 doubled the import time for our performance test model, but the check there was too lax to catch it. Sometimes, `smart_subs_dict` is applied to individual expressions, sometimes to complete matrices. If it's only applied to individual expressions or small matrices, avoid the overhead of flattening the substitutions first. Update the time limits for the performance tests to catch such regressions earlier. Fixes AMICI-dev#3048.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
Unfortunately, #3030 doubled the import time for our performance test model, but the check there was too lax to catch it. Sometimes, `smart_subs_dict` is applied to individual expressions, sometimes to complete matrices. If it's only applied to individual expressions or small matrices, avoid the overhead of flattening the substitutions first. Update the time limits for the performance tests to catch such regressions earlier. Fixes #3048.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten out expressions first to avoid expensive repeated substitutions in matrices.
For my current benchmark, this yields another 10x improvement compared to #3025.