Skip to content

Let froot depend on w #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 1 commit into from
Nov 18, 2025

Let `froot` depend on `w`

c95ca0e
Select commit
Loading
Failed to load commit list.
Merged

Let froot depend on w #3031

Let `froot` depend on `w`
c95ca0e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 18, 2025 in 1s

77.55% (-0.59%) compared to 8fc33dc

View this Pull Request on Codecov

77.55% (-0.59%) compared to 8fc33dc

Details

Codecov Report

❌ Patch coverage is 68.75000% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.55%. Comparing base (8fc33dc) to head (c95ca0e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
models/model_events_py/model_events_py.h 54.54% 5 Missing ⚠️
...odel_jakstat_adjoint_py/model_jakstat_adjoint_py.h 16.66% 5 Missing ⚠️
...ls/model_nested_events_py/model_nested_events_py.h 54.54% 5 Missing ⚠️
models/model_neuron_py/model_neuron_py.h 50.00% 5 Missing ⚠️
models/model_robertson_py/model_robertson_py.h 16.66% 5 Missing ⚠️
models/model_steadystate_py/model_steadystate_py.h 16.66% 5 Missing ⚠️
models/model_calvetti_py/model_calvetti_py.h 50.00% 4 Missing ⚠️
models/model_dirac_py/model_dirac_py.h 60.00% 4 Missing ⚠️
models/model_dirac_py/deltaqB.cpp 0.00% 1 Missing ⚠️
models/model_events_py/deltaqB.cpp 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
- Coverage   78.14%   77.55%   -0.59%     
==========================================
  Files         311      311              
  Lines       20593    20622      +29     
  Branches     1499     1501       +2     
==========================================
- Hits        16092    15993      -99     
- Misses       4491     4619     +128     
  Partials       10       10
Files with missing lines Coverage Δ
include/amici/abstract_model.h 100.00% <ø> (ø)
include/amici/model.h 78.04% <ø> (ø)
include/amici/model_dae.h 80.00% <ø> (ø)
include/amici/model_ode.h 100.00% <ø> (ø)
models/model_calvetti_py/explicit_roots.cpp 100.00% <100.00%> (ø)
models/model_calvetti_py/root.cpp 100.00% <100.00%> (ø)
models/model_dirac_py/explicit_roots.cpp 100.00% <100.00%> (ø)
models/model_dirac_py/root.cpp 100.00% <100.00%> (ø)
models/model_dirac_py/stau.cpp 100.00% <100.00%> (ø)
models/model_events_py/explicit_roots.cpp 100.00% <100.00%> (ø)
... and 31 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov