Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 13, 2025

  • update version number - missed update on main
  • regenerate test models - missed updating after recent changes to the templates

* update version number - missed update on `main`
* regenerate test models - missed updating after recent changes to the templates
@dweindl dweindl requested a review from a team as a code owner November 13, 2025 21:14
@dweindl dweindl enabled auto-merge November 13, 2025 21:14
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedamici@​0.34.1 ⏵ 0.34.296 +110010010070

View full report

@dweindl dweindl self-assigned this Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.40%. Comparing base (b0b2684) to head (c95694b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
models/model_calvetti_py/model_calvetti_py.h 0.00% 2 Missing ⚠️
models/model_dirac_py/model_dirac_py.h 0.00% 2 Missing ⚠️
models/model_events_py/model_events_py.h 0.00% 2 Missing ⚠️
...odel_jakstat_adjoint_py/model_jakstat_adjoint_py.h 0.00% 2 Missing ⚠️
...ls/model_nested_events_py/model_nested_events_py.h 0.00% 2 Missing ⚠️
models/model_neuron_py/model_neuron_py.h 0.00% 2 Missing ⚠️
models/model_robertson_py/model_robertson_py.h 0.00% 2 Missing ⚠️
models/model_steadystate_py/model_steadystate_py.h 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3032      +/-   ##
==========================================
- Coverage   78.06%   77.40%   -0.67%     
==========================================
  Files         311      311              
  Lines       20587    20587              
  Branches     1499     1500       +1     
==========================================
- Hits        16071    15935     -136     
- Misses       4506     4642     +136     
  Partials       10       10              
Flag Coverage Δ
cpp 70.33% <0.00%> (-0.03%) ⬇️
cpp_python 36.75% <0.00%> (ø)
petab 45.72% <ø> (ø)
petab_sciml 13.66% <ø> (ø)
python 69.33% <0.00%> (-0.03%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
models/model_calvetti_py/model_calvetti_py.h 57.76% <0.00%> (ø)
models/model_dirac_py/model_dirac_py.h 58.16% <0.00%> (ø)
models/model_events_py/model_events_py.h 65.69% <0.00%> (ø)
...odel_jakstat_adjoint_py/model_jakstat_adjoint_py.h 69.87% <0.00%> (ø)
...ls/model_nested_events_py/model_nested_events_py.h 62.65% <0.00%> (ø)
models/model_neuron_py/model_neuron_py.h 71.85% <0.00%> (ø)
models/model_robertson_py/model_robertson_py.h 53.37% <0.00%> (ø)
models/model_steadystate_py/model_steadystate_py.h 62.16% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added this pull request to the merge queue Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2025
@dweindl dweindl merged commit e75c348 into AMICI-dev:main Nov 14, 2025
24 of 26 checks passed
@dweindl dweindl deleted the update_models branch November 14, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants