Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 13, 2025

Fixes a flaw in cmake/AmiciFindBLAS.cmake that resulted in incorrectly trying to use scipy-openblas during standalone C++ builds. Now, unless explicitly requested, scipy-openblas will only be considered when building (only) the Python extension.

Fixes a flaw in `cmake/AmiciFindBLAS.cmake` that resulted in incorrectly trying to use scipy-openblas during standalone C++ builds.
Now, unless explicitly requested, scipy-openblas will only be considered when building (only) the Python extension.
@dweindl dweindl requested a review from a team as a code owner November 13, 2025 21:20
@dweindl dweindl enabled auto-merge November 13, 2025 21:21
@dweindl dweindl self-assigned this Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.40%. Comparing base (b0b2684) to head (a699c60).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3033      +/-   ##
==========================================
- Coverage   78.06%   77.40%   -0.67%     
==========================================
  Files         311      311              
  Lines       20587    20587              
  Branches     1499     1499              
==========================================
- Hits        16071    15935     -136     
- Misses       4506     4642     +136     
  Partials       10       10              
Flag Coverage Δ
cpp 70.33% <ø> (-0.03%) ⬇️
cpp_python 36.75% <ø> (ø)
petab 45.72% <ø> (ø)
petab_sciml 13.66% <ø> (ø)
python 69.33% <ø> (-0.03%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added this pull request to the merge queue Nov 13, 2025
Merged via the queue into AMICI-dev:main with commit 27d4d38 Nov 14, 2025
25 of 26 checks passed
@dweindl dweindl deleted the fix_cmake_blas branch November 14, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants