Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 17, 2025

With generate_sensitivity_code=False, amici still generated some unnecessary event sensivity functions. This is fixed here.

With `generate_sensitivity_code=False`, amici still generated some unnecessary event sensivity functions. This is fixed here.
@dweindl dweindl self-assigned this Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.45%. Comparing base (9c82549) to head (f2cae53).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
- Coverage   78.10%   77.45%   -0.65%     
==========================================
  Files         311      311              
  Lines       20580    20580              
  Branches     1499     1499              
==========================================
- Hits        16073    15940     -133     
- Misses       4497     4630     +133     
  Partials       10       10              
Flag Coverage Δ
cpp 70.71% <ø> (ø)
cpp_python 37.19% <ø> (ø)
petab 45.86% <ø> (ø)
petab_sciml 13.75% <ø> (ø)
python 69.37% <ø> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...on/sdist/amici/exporters/sundials/cxx_functions.py 97.14% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review November 17, 2025 13:16
@dweindl dweindl requested a review from a team as a code owner November 17, 2025 13:16
@dweindl dweindl enabled auto-merge November 17, 2025 13:16
@dweindl dweindl added this pull request to the merge queue Nov 17, 2025
Merged via the queue into AMICI-dev:main with commit baed9cd Nov 17, 2025
25 of 26 checks passed
@dweindl dweindl deleted the fix_no_sens branch November 17, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants