Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 17, 2025

With #3036, the ordering of w symbols and expressions has changed. This is not a problem per se, but would require recreating the test oracles for the models in models/.
Therefore, don't do any unnecessary reordering.

@dweindl dweindl self-assigned this Nov 17, 2025
@dweindl dweindl requested a review from a team as a code owner November 17, 2025 20:44
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.44%. Comparing base (6039cec) to head (890c839).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3051      +/-   ##
==========================================
- Coverage   78.13%   77.44%   -0.70%     
==========================================
  Files         311      311              
  Lines       20589    20593       +4     
  Branches     1499     1499              
==========================================
- Hits        16088    15948     -140     
- Misses       4491     4635     +144     
  Partials       10       10              
Flag Coverage Δ
cpp 70.70% <100.00%> (-0.05%) ⬇️
cpp_python 37.17% <71.42%> (-0.04%) ⬇️
petab 45.81% <71.42%> (-0.04%) ⬇️
petab_sciml 13.80% <85.71%> (+0.01%) ⬆️
python 69.38% <100.00%> (-0.04%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_model.py 91.55% <100.00%> (-0.12%) ⬇️
python/sdist/amici/importers/sbml/__init__.py 82.50% <100.00%> (-11.95%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl enabled auto-merge November 17, 2025 21:20
@dweindl dweindl added this pull request to the merge queue Nov 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 17, 2025
With AMICI-dev#3036, the ordering of `w` symbols and expressions has changed.
This is not a problem per se, but would require recreating the
test oracles for the models in `models/`.
Therefore, don't do any unnecessary reordering.
@dweindl dweindl enabled auto-merge November 18, 2025 06:04
@dweindl dweindl added this pull request to the merge queue Nov 18, 2025
Merged via the queue into AMICI-dev:main with commit 8fc33dc Nov 18, 2025
33 of 35 checks passed
@dweindl dweindl deleted the restore_w_order branch November 18, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants