Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 18, 2025

Fix generating xarrays in ReturnData.xr.*. Broke during renaming 'parameters'. Increase test coverage.

@dweindl dweindl self-assigned this Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.61%. Comparing base (63f2e78) to head (2ed991c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/sim/sundials/_numpy.py 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3054      +/-   ##
==========================================
- Coverage   78.16%   77.61%   -0.55%     
==========================================
  Files         313      313              
  Lines       20656    20661       +5     
  Branches     1500     1499       -1     
==========================================
- Hits        16145    16037     -108     
- Misses       4502     4615     +113     
  Partials        9        9              
Flag Coverage Δ
cpp 71.71% <83.33%> (+0.10%) ⬆️
cpp_python 37.24% <16.66%> (-0.01%) ⬇️
petab 45.86% <16.66%> (-0.01%) ⬇️
petab_sciml 13.83% <16.66%> (+<0.01%) ⬆️
python 70.31% <83.33%> (+0.10%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sim/sundials/_numpy.py 87.42% <83.33%> (+12.74%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review November 18, 2025 12:35
@dweindl dweindl requested a review from a team as a code owner November 18, 2025 12:35
Fix generating xarrays in `ReturnData.xr.*`. Broke during renaming 'parameters'. Increase test coverage.
@dweindl dweindl added this pull request to the merge queue Nov 20, 2025
Merged via the queue into AMICI-dev:main with commit d0957d2 Nov 20, 2025
25 of 26 checks passed
@dweindl dweindl deleted the fix-rdata-xr branch November 20, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants