Remove auto-generated flux_r0 expression in models without reactions
#3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3057 +/- ##
===========================================
- Coverage 78.15% 49.57% -28.59%
===========================================
Files 312 312
Lines 20643 20647 +4
Branches 1499 1499
===========================================
- Hits 16133 10235 -5898
- Misses 4500 10304 +5804
- Partials 10 108 +98
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
Almost. |
dweindl
force-pushed
the
no_flux_r0
branch
2 times, most recently
from
a876228 to
1cbe6b3
Compare
This may have been necessary with earlier sympy versions, but I don't think we still need that. Let's not make users wonder where that expression comes from. Closes AMICI-dev#3045.
Member
Author
|
The stored test results need updating because |
FFroehlich
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may have been necessary with earlier sympy versions, but I don't think we still need that. Let's not make users wonder where that expression comes from.
Closes #3045.