Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 18, 2025

Closes #3040.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.15%. Comparing base (5b6d241) to head (27977b0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hon/sdist/amici/importers/petab/_petab_importer.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3058      +/-   ##
==========================================
+ Coverage   78.13%   78.15%   +0.02%     
==========================================
  Files         311      312       +1     
  Lines       20641    20643       +2     
  Branches     1499     1499              
==========================================
+ Hits        16127    16133       +6     
+ Misses       4504     4500       -4     
  Partials       10       10              
Flag Coverage Δ
cpp 70.79% <62.50%> (+0.02%) ⬆️
cpp_python 37.24% <62.50%> (+<0.01%) ⬆️
petab 45.86% <87.50%> (+<0.01%) ⬆️
petab_sciml 13.78% <37.50%> (+0.01%) ⬆️
python 69.44% <62.50%> (+0.01%) ⬆️
sbmlsuite-jax 32.71% <37.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/_symbolic/__init__.py 100.00% <100.00%> (ø)
python/sdist/amici/_symbolic/de_model.py 91.86% <ø> (ø)
...ython/sdist/amici/_symbolic/de_model_components.py 93.10% <ø> (ø)
python/sdist/amici/_symbolic/sympy_utils.py 78.87% <100.00%> (ø)
python/sdist/amici/exporters/sundials/de_export.py 96.38% <100.00%> (ø)
python/sdist/amici/importers/pysb/__init__.py 94.54% <ø> (ø)
python/sdist/amici/importers/sbml/__init__.py 94.45% <ø> (ø)
python/sdist/amici/jax/ode_export.py 88.33% <ø> (ø)
...hon/sdist/amici/importers/petab/_petab_importer.py 89.69% <66.66%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review November 19, 2025 08:13
@dweindl dweindl requested a review from a team as a code owner November 19, 2025 08:13
@dweindl dweindl changed the title Move symbolic model to amici.symbolic Move symbolic model to amici._symbolic Nov 19, 2025
@dweindl dweindl merged commit 20b07e9 into AMICI-dev:main Nov 19, 2025
35 checks passed
@dweindl dweindl deleted the amici_dot_symbolic branch November 19, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move symbolic model code to subpackage

2 participants