Update python/sdist/amici/include/ symlinks
#3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't symlink `python/sdist/amici/include/`, as done so far. Instead, symlink `python/sdist/amici/include/amici`. This prevents editable installations messing up `include/`. For example, after an editable installation with scipy-openblas, the plain c++ build would fail because of a `cblas.h` added to `include/`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3066 +/- ##
==========================================
- Coverage 78.16% 77.52% -0.64%
==========================================
Files 313 313
Lines 20656 20656
Branches 1500 1499 -1
==========================================
- Hits 16145 16014 -131
- Misses 4502 4633 +131
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't symlink
python/sdist/amici/include/, as done so far. Instead, symlinkpython/sdist/amici/include/amici. This prevents editable installations messing upinclude/. For example, after an editable installation with scipy-openblas, the plain c++ build would fail because of acblas.hadded toinclude/.