Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 4, 2025

  • Re-export import_model_module.
  • Set __all__

The goal should be that after having compiled a model, for most applications, the only required import for loading and simulating that model is amici.sim.sundials.

@dweindl dweindl self-assigned this Dec 4, 2025
@dweindl dweindl force-pushed the import_mm branch 5 times, most recently from 11813ec to a7cf440 Compare December 4, 2025 08:21
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.41%. Comparing base (4ca828f) to head (ee52cfc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3082      +/-   ##
==========================================
- Coverage   78.07%   77.41%   -0.66%     
==========================================
  Files         312      312              
  Lines       20494    20496       +2     
  Branches     1500     1500              
==========================================
- Hits        16000    15868     -132     
- Misses       4485     4619     +134     
  Partials        9        9              
Flag Coverage Δ
cpp 71.46% <100.00%> (+<0.01%) ⬆️
cpp_python 37.51% <100.00%> (+<0.01%) ⬆️
petab 46.29% <100.00%> (+<0.01%) ⬆️
petab_sciml 13.87% <100.00%> (+0.01%) ⬆️
python 70.10% <100.00%> (+<0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sim/sundials/__init__.py 85.71% <100.00%> (+2.38%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the import_mm branch 3 times, most recently from 0ee82ef to 0c5d306 Compare December 4, 2025 14:06
@dweindl dweindl marked this pull request as ready for review December 4, 2025 14:30
@dweindl dweindl requested a review from a team as a code owner December 4, 2025 14:30
@dweindl dweindl added this pull request to the merge queue Dec 4, 2025
@dweindl dweindl removed this pull request from the merge queue due to a manual request Dec 4, 2025
@dweindl dweindl enabled auto-merge December 4, 2025 18:42
* Re-export `import_model_module`.
* Set `__all__`

The goal should be that after having compiled a model, for most applications, the only required import for loading and simulating that model is `amici.sim.sundials`.
@dweindl dweindl added this pull request to the merge queue Dec 4, 2025
Merged via the queue into AMICI-dev:main with commit a8dfd6e Dec 4, 2025
25 of 26 checks passed
@dweindl dweindl deleted the import_mm branch December 8, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants