Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 4, 2025

This was supposed to be removed already in #3064. Looks like some merge issue with #3060.

This was supposed to be removed already in AMICI-dev#3064. Looks like some merge issue with AMICI-dev#3060.
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.41%. Comparing base (e32d65c) to head (72fa72c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
- Coverage   77.74%   77.41%   -0.34%     
==========================================
  Files         313      312       -1     
  Lines       20678    20494     -184     
  Branches     1500     1500              
==========================================
- Hits        16077    15866     -211     
- Misses       4592     4619      +27     
  Partials        9        9              
Flag Coverage Δ
cpp 71.46% <ø> (+0.26%) ⬆️
cpp_python 37.50% <ø> (+0.24%) ⬆️
petab 46.28% <ø> (+0.37%) ⬆️
petab_sciml 13.86% <ø> (+0.03%) ⬆️
python 70.10% <ø> (+0.26%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sim/sundials/__init__.py 83.33% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review December 4, 2025 09:08
@dweindl dweindl requested a review from a team as a code owner December 4, 2025 09:08
@dweindl dweindl enabled auto-merge December 4, 2025 13:20
@dweindl dweindl self-assigned this Dec 4, 2025
@dweindl dweindl added this pull request to the merge queue Dec 4, 2025
Merged via the queue into AMICI-dev:main with commit 4ca828f Dec 4, 2025
25 of 26 checks passed
@dweindl dweindl deleted the remove_pandas branch December 4, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants