Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 8, 2025

Related to #3041.

@dweindl dweindl self-assigned this Dec 8, 2025
@dweindl dweindl force-pushed the sim_petab branch 2 times, most recently from bb5d6ed to 97a66dd Compare December 8, 2025 20:10
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.42%. Comparing base (a8dfd6e) to head (58df9dd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
- Coverage   78.10%   77.42%   -0.69%     
==========================================
  Files         312      313       +1     
  Lines       20496    20497       +1     
  Branches     1500     1500              
==========================================
- Hits        16008    15869     -139     
- Misses       4479     4619     +140     
  Partials        9        9              
Flag Coverage Δ
cpp 71.56% <100.00%> (+0.06%) ⬆️
cpp_python 37.61% <100.00%> (+0.09%) ⬆️
petab 46.29% <100.00%> (+<0.01%) ⬆️
petab_sciml 13.72% <0.00%> (-0.16%) ⬇️
python 70.20% <100.00%> (+0.06%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/adapters/fiddy.py 78.51% <ø> (ø)
...hon/sdist/amici/importers/petab/_petab_importer.py 89.69% <ø> (ø)
python/sdist/amici/importers/petab/v1/__init__.py 100.00% <ø> (ø)
...thon/sdist/amici/sim/sundials/petab/v1/__init__.py 100.00% <100.00%> (ø)
...n/sdist/amici/sim/sundials/petab/v1/_conditions.py 98.33% <ø> (ø)
...dist/amici/sim/sundials/petab/v1/_petab_problem.py 89.23% <ø> (ø)
.../sdist/amici/sim/sundials/petab/v1/_simulations.py 94.73% <ø> (ø)
...on/sdist/amici/sim/sundials/petab/v1/_simulator.py 96.66% <ø> (ø)
python/tests/petab_/test_petab_problem.py 100.00% <ø> (ø)
python/tests/test_petab_objective.py 100.00% <ø> (ø)
... and 1 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the sim_petab branch 2 times, most recently from c338c32 to 894a52a Compare December 8, 2025 21:05
@dweindl dweindl marked this pull request as ready for review December 9, 2025 12:09
@dweindl dweindl requested a review from a team as a code owner December 9, 2025 12:09
@dweindl dweindl added this pull request to the merge queue Dec 9, 2025
Merged via the queue into AMICI-dev:main with commit e6863a9 Dec 9, 2025
25 of 26 checks passed
@dweindl dweindl deleted the sim_petab branch December 9, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants