Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 9, 2025

  • disable module scanning to work with missing clang-scan-deps under macOS/conda
  • store OpenMP config in amici-core CMake configuration file as fallback if FindOpenMP fails
  • require model import tests to pass

Closes #3028

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.42%. Comparing base (e6863a9) to head (c57249d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3089      +/-   ##
==========================================
- Coverage   78.07%   77.42%   -0.66%     
==========================================
  Files         313      313              
  Lines       20497    20497              
  Branches     1500     1500              
==========================================
- Hits        16003    15869     -134     
- Misses       4485     4619     +134     
  Partials        9        9              
Flag Coverage Δ
cpp 71.56% <ø> (ø)
cpp_python 37.61% <ø> (ø)
petab 46.29% <ø> (ø)
petab_sciml 13.72% <ø> (ø)
python 70.20% <ø> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the gh-3028-test-conda-model-import branch 3 times, most recently from e629d35 to 919f90d Compare December 9, 2025 14:14
* disable module scanning to work with missing clang-scan-deps under macOS/conda
* store OpenMP config in amici-core CMake configuration file as fallback if FindOpenMP fails
* require model import tests to pass
@dweindl dweindl force-pushed the gh-3028-test-conda-model-import branch from 4c5ec95 to c57249d Compare December 9, 2025 15:21
@dweindl dweindl marked this pull request as ready for review December 9, 2025 15:26
@dweindl dweindl requested a review from a team as a code owner December 9, 2025 15:26
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dweindl dweindl merged commit f4f401f into AMICI-dev:main Dec 9, 2025
25 of 26 checks passed
@dweindl dweindl deleted the gh-3028-test-conda-model-import branch December 9, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix building model extensions under conda on macos

2 participants