Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 9, 2025

Unused. Unlikely to be useful.

Unused. Unlikely to be useful.
@dweindl dweindl changed the title Remove sbml_import.species_to_parameters Remove sbml_import.species_to_parameters Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.47%. Comparing base (e6863a9) to head (3c7cd70).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3090      +/-   ##
==========================================
- Coverage   78.07%   77.47%   -0.61%     
==========================================
  Files         313      313              
  Lines       20497    20469      -28     
  Branches     1500     1500              
==========================================
- Hits        16003    15858     -145     
- Misses       4485     4602     +117     
  Partials        9        9              
Flag Coverage Δ
cpp 71.60% <ø> (+0.04%) ⬆️
cpp_python 37.65% <ø> (+0.04%) ⬆️
petab 46.36% <ø> (+0.06%) ⬆️
petab_sciml 13.73% <ø> (+0.01%) ⬆️
python 70.24% <ø> (+0.04%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...thon/sdist/amici/importers/petab/v1/sbml_import.py 97.75% <ø> (+22.53%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review December 9, 2025 17:05
@dweindl dweindl requested a review from a team as a code owner December 9, 2025 17:05
@dweindl dweindl self-assigned this Dec 9, 2025
@dweindl dweindl added this pull request to the merge queue Dec 9, 2025
Merged via the queue into AMICI-dev:main with commit c64ec7a Dec 9, 2025
27 of 29 checks passed
@dweindl dweindl deleted the rm_species_to_parameters branch December 9, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants