Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 9, 2025

Simplify some imports. Fix type annotations. Import extension types only where necessary.

@dweindl dweindl self-assigned this Dec 9, 2025
@dweindl dweindl marked this pull request as ready for review December 9, 2025 18:14
@dweindl dweindl requested a review from a team as a code owner December 9, 2025 18:14
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.53%. Comparing base (1a80258) to head (7c110a6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3092      +/-   ##
==========================================
- Coverage   78.22%   77.53%   -0.70%     
==========================================
  Files         315      315              
  Lines       20480    20481       +1     
  Branches     1500     1500              
==========================================
- Hits        16021    15880     -141     
- Misses       4450     4592     +142     
  Partials        9        9              
Flag Coverage Δ
cpp 71.67% <100.00%> (-0.04%) ⬇️
cpp_python 37.68% <75.00%> (-0.01%) ⬇️
petab 46.39% <75.00%> (-0.01%) ⬇️
petab_sciml 13.75% <75.00%> (-0.01%) ⬇️
python 70.31% <100.00%> (-0.04%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/importers/pysb/__init__.py 94.64% <ø> (ø)
python/sdist/amici/importers/sbml/__init__.py 82.31% <ø> (-11.99%) ⬇️
.../amici/importers/sbml/conserved_quantities_rref.py 96.49% <100.00%> (ø)
python/sdist/amici/sim/sundials/_numpy.py 87.42% <100.00%> (ø)
python/sdist/amici/sim/sundials/gradient_check.py 93.38% <ø> (-6.62%) ⬇️
...thon/sdist/amici/sim/sundials/petab/v1/__init__.py 100.00% <ø> (ø)
.../sdist/amici/sim/sundials/petab/v1/_simulations.py 94.73% <ø> (ø)
python/sdist/amici/testing/models.py 98.38% <100.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added this pull request to the merge queue Dec 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 10, 2025
Simplify some imports. Fix type annotations. Import extension types only where necessary.
@dweindl dweindl merged commit 6b3bf83 into AMICI-dev:main Dec 10, 2025
31 of 32 checks passed
@dweindl dweindl deleted the import_export branch December 10, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants