Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 10, 2025

  • Exclude private members from the sphinx documentation
  • Make some supposed-to-be-private members private
  • Fix references

To be continued...

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 84.46602% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.60%. Comparing base (6b3bf83) to head (d7f9c1e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/importers/sbml/__init__.py 83.75% 32 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
- Coverage   78.18%   77.60%   -0.59%     
==========================================
  Files         315      315              
  Lines       20481    20466      -15     
  Branches     1500     1500              
==========================================
- Hits        16014    15882     -132     
- Misses       4458     4575     +117     
  Partials        9        9              
Flag Coverage Δ
cpp 71.73% <83.00%> (+0.06%) ⬆️
cpp_python 37.73% <63.10%> (+0.05%) ⬆️
petab 46.46% <74.75%> (+0.06%) ⬆️
petab_sciml 13.79% <54.36%> (+0.04%) ⬆️
python 70.37% <84.46%> (+0.06%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/__init__.py 95.16% <ø> (ø)
python/sdist/amici/adapters/fiddy.py 89.56% <100.00%> (+11.04%) ⬆️
python/sdist/amici/exporters/sundials/de_export.py 96.38% <ø> (ø)
python/sdist/amici/importers/antimony/__init__.py 83.33% <ø> (ø)
...thon/sdist/amici/importers/petab/v1/sbml_import.py 97.75% <ø> (ø)
python/sdist/amici/importers/pysb/__init__.py 94.64% <ø> (ø)
python/sdist/amici/importers/sbml/splines.py 80.62% <100.00%> (ø)
python/sdist/amici/importers/utils.py 83.33% <ø> (-2.71%) ⬇️
python/tests/conftest.py 43.33% <ø> (ø)
python/tests/test_petab_import.py 100.00% <ø> (ø)
... and 1 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the doc_misc branch 4 times, most recently from d75f2e6 to 6d13126 Compare December 10, 2025 13:45
@dweindl dweindl marked this pull request as ready for review December 10, 2025 13:58
@dweindl dweindl requested a review from a team as a code owner December 10, 2025 13:58
* Exclude private members from the sphinx documentation
* Make some supposed-to-be-private members private
* Fix references
* Fix docstrings

To be continued...
@dweindl dweindl merged commit d578a31 into AMICI-dev:main Dec 10, 2025
31 of 32 checks passed
@dweindl dweindl deleted the doc_misc branch December 10, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants