Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 11, 2025

Require keyword arguments for a couple of functions.

Closes #3099.

@dweindl dweindl self-assigned this Dec 11, 2025
@dweindl dweindl added the breaking change Issue changes API in backwards-incompatible way label Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.59%. Comparing base (a724161) to head (6a4fa65).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
- Coverage   78.25%   77.59%   -0.66%     
==========================================
  Files         315      315              
  Lines       20464    20464              
  Branches     1500     1501       +1     
==========================================
- Hits        16014    15880     -134     
- Misses       4441     4575     +134     
  Partials        9        9              
Flag Coverage Δ
cpp 71.74% <100.00%> (ø)
cpp_python 37.73% <0.00%> (ø)
petab 46.46% <33.33%> (ø)
petab_sciml 13.79% <0.00%> (ø)
python 70.37% <100.00%> (ø)
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/adapters/fiddy.py 89.56% <ø> (ø)
python/sdist/amici/importers/antimony/__init__.py 83.33% <100.00%> (ø)
python/sdist/amici/importers/bngl/__init__.py 100.00% <100.00%> (ø)
...hon/sdist/amici/importers/petab/v1/petab_import.py 100.00% <ø> (ø)
python/sdist/amici/importers/pysb/__init__.py 94.64% <ø> (ø)
python/sdist/amici/importers/sbml/__init__.py 82.40% <ø> (-11.93%) ⬇️
python/sdist/amici/importers/utils.py 83.18% <ø> (-2.73%) ⬇️
python/sdist/amici/sim/sundials/gradient_check.py 93.38% <ø> (ø)
python/sdist/amici/sim/sundials/petab/_v2.py 94.06% <ø> (ø)
.../sdist/amici/sim/sundials/petab/v1/_simulations.py 94.73% <ø> (ø)
... and 1 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the kwargs branch 2 times, most recently from 5ef9147 to cceb21e Compare December 11, 2025 16:30
@dweindl dweindl marked this pull request as ready for review December 12, 2025 06:43
@dweindl dweindl requested a review from a team as a code owner December 12, 2025 06:43
Require keyword arguments for a couple of functions.

Closes AMICI-dev#3099.
@dweindl dweindl enabled auto-merge December 12, 2025 08:13
@dweindl dweindl added this pull request to the merge queue Dec 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2025
@dweindl dweindl merged commit 8603c1e into AMICI-dev:main Dec 12, 2025
33 of 35 checks passed
@dweindl dweindl deleted the kwargs branch December 12, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Issue changes API in backwards-incompatible way

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require kwargs

2 participants