Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 16, 2025

  • Remove the remainder of the old monkey-patching to store model entity names and IDs on ReturnData for RDataReporting::full.
  • Update/simplify plotting functions accordingly
  • Update getting-started notebook and documentation

Related to #3107.

@dweindl dweindl self-assigned this Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.56%. Comparing base (505a137) to head (929c856).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/sim/sundials/plotting.py 0.00% 13 Missing ⚠️
python/sdist/amici/sim/sundials/_numpy.py 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3112      +/-   ##
==========================================
- Coverage   78.26%   77.56%   -0.70%     
==========================================
  Files         315      315              
  Lines       20487    20482       -5     
  Branches     1484     1484              
==========================================
- Hits        16034    15887     -147     
- Misses       4445     4587     +142     
  Partials        8        8              
Flag Coverage Δ
cpp 71.69% <30.00%> (-0.04%) ⬇️
cpp_python 37.85% <0.00%> (+<0.01%) ⬆️
petab 46.56% <0.00%> (+0.01%) ⬆️
petab_sciml 13.93% <0.00%> (+<0.01%) ⬆️
python 70.35% <30.00%> (-0.03%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sim/sundials/_numpy.py 88.46% <85.71%> (+1.04%) ⬆️
python/sdist/amici/sim/sundials/plotting.py 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the gh-3107-use-rdata-ids branch from c698f72 to b924ba8 Compare December 16, 2025 14:31
Remove the remainder of the old monkey-patching to store model entity names and IDs on `ReturnData` for `RDataReporting::full`.
@dweindl dweindl force-pushed the gh-3107-use-rdata-ids branch from b924ba8 to 929c856 Compare December 16, 2025 22:32
@dweindl dweindl marked this pull request as ready for review December 17, 2025 15:03
@dweindl dweindl requested a review from a team as a code owner December 17, 2025 15:03
Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dweindl dweindl added this pull request to the merge queue Dec 17, 2025
Merged via the queue into AMICI-dev:main with commit 6e12168 Dec 17, 2025
24 of 26 checks passed
@dweindl dweindl deleted the gh-3107-use-rdata-ids branch December 17, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants