Skip to content

update pressure via eos when transverse_use_eos=1#3004

Merged
zingale merged 9 commits intoAMReX-Astro:developmentfrom
zhichen3:fix_transverse_use_eos
Dec 13, 2024
Merged

update pressure via eos when transverse_use_eos=1#3004
zingale merged 9 commits intoAMReX-Astro:developmentfrom
zhichen3:fix_transverse_use_eos

Conversation

@zhichen3
Copy link
Collaborator

PR summary

this is to address issue #3003

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member

zingale commented Dec 13, 2024

@zingale
Copy link
Member

zingale commented Dec 13, 2024

don't we also need to fix actual_trans_final?

@zhichen3
Copy link
Collaborator Author

okie, just added it.

@zingale zingale merged commit 4b1162f into AMReX-Astro:development Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants