Skip to content

Conversation

@zingale
Copy link
Member

@zingale zingale commented Dec 12, 2025

this pulls that out.
A later optimization is to precompute the inverse, but that introduces roundoff diffs, so I'll save that for a follow-on PR

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale changed the title in the transverse update we were recomputing density every passive lo… in the transverse update we recomputed density every passive iteration Dec 12, 2025
@zingale
Copy link
Member Author

zingale commented Dec 17, 2025

this seems to perhaps slow things down?

http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2025-12-17-001/index.html

@zingale
Copy link
Member Author

zingale commented Dec 17, 2025

tests pass now:
http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2025-12-17-003/index.html

I'll do a follow-on PR introducing the 1/rho temporary, which causes roundoff diffs

@zingale
Copy link
Member Author

zingale commented Dec 22, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant