-
Notifications
You must be signed in to change notification settings - Fork 105
Update WD merger inputs #3201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khanakbhargava
wants to merge
2
commits into
AMReX-Astro:development
Choose a base branch
from
khanakbhargava:inputs
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update WD merger inputs #3201
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| ## Latest inputs file being used to reproduce initial conditions from Pakmor et al. 2022 | ||
| ## with 12 km resolution | ||
| # 50 km with burning in shock disabled, clipping off, w/ SDC, on GPUs. | ||
| # Updated: Jan 29, 2026 | ||
|
|
||
| ############################## CASTRO INPUTS ############################################### | ||
|
|
||
|
|
@@ -73,7 +73,7 @@ castro.fixed_dt = -1.0 | |
| castro.init_shrink = 0.1 | ||
|
|
||
| # Factor by which dt is allowed to change each timestep | ||
| castro.change_max = 1.20 | ||
| castro.change_max = 1.2 # default was initially 1.30 but we did tests and agreed to do 1.2 !kb | ||
|
|
||
| # If we regrid on Level 0, compute a new timestep afterward | ||
| amr.compute_new_dt_on_regrid = 1 | ||
|
|
@@ -92,8 +92,7 @@ castro.abundance_failure_rho_cutoff = 1.0e0 | |
| castro.max_subcycles = 16 | ||
|
|
||
| # Switching to simplified SDC | ||
| castro.time_integration_method = 3 | ||
|
|
||
| castro.time_integration_method = 3 ## my main goal is to test SDC for DD !kb | ||
|
|
||
| ############################################################################################ | ||
| # Resolution, gridding and AMR | ||
|
|
@@ -115,7 +114,7 @@ castro.time_integration_method = 3 | |
| amr.max_level = 3 | ||
|
|
||
| # Refinement ratio | ||
| amr.ref_ratio = 4 4 4 | ||
| amr.ref_ratio = 4 2 2 | ||
|
|
||
| # How many coarse timesteps between regridding | ||
| amr.regrid_int = 2 | ||
|
|
@@ -142,7 +141,7 @@ castro.state_interp_order = 0 | |
| castro.lin_limit_state_interp = 1 | ||
|
|
||
| # Add refinement indicators | ||
| amr.refinement_indicators = density density2 temperature | ||
| amr.refinement_indicators = density density2 temperature ## added a second density criteria for better refinement !kb | ||
|
|
||
| # Density refinement criterion | ||
| amr.refine.density.value_greater = 1.0e0 | ||
|
|
@@ -152,7 +151,7 @@ amr.refine.density.max_level = 1 | |
| # Density2 refinement criterion | ||
| amr.refine.density2.value_greater = 1.0e4 | ||
| amr.refine.density2.field_name = density | ||
| amr.refine.density2.max_level = 20 | ||
| amr.refine.density2.max_level = 14 ## only for debugging | ||
|
|
||
| # Temperature refinement criterion | ||
| amr.refine.temperature.value_greater = 3.0e8 | ||
|
|
@@ -163,10 +162,13 @@ amr.refine.temperature.max_level = 3 | |
| castro.max_tagging_radius = 0.75e0 | ||
|
|
||
| # Whether or not to use AMR subcycling | ||
| amr.subcycling_mode = None | ||
| amr.subcycling_mode = None ## we do not want AMR subcycling because it is faster this way !kb | ||
|
|
||
| # GPU option | ||
| castro.hydro_memory_footprint_ratio = 3 | ||
| castro.hydro_memory_footprint_ratio = 3 ## this was added !kb | ||
|
|
||
| ## debug only | ||
| #amrex.fpe_trap_invalid=1 | ||
|
|
||
| ############################################################################################ | ||
| # Physics to include | ||
|
|
@@ -308,10 +310,13 @@ network.use_tables = 0 | |
| # reactions go faster | ||
| integrator.use_burn_retry = 1 | ||
| integrator.retry_swap_jacobian = 1 | ||
| integrator.ode_max_steps = 10000 | ||
| integrator.ode_max_steps = 100000 | ||
|
|
||
| # Disable burning in shocks | ||
| castro.disable_shock_burning = 1 | ||
| castro.disable_shock_burning = 1 ## in general this is better for DD so I want to run with this !kb | ||
|
|
||
| # Turn off clipping to make work easy for integrator | ||
| integrator.do_species_clip = 0 ## MZ suggested this should be done !kb | ||
|
|
||
| ############################################################################################ | ||
| # Gravity | ||
|
|
@@ -374,7 +379,7 @@ castro.gw_dist = 10.0 | |
| castro.job_name = wdmerger | ||
|
|
||
| # Whether or not to output plotfiles | ||
| amr.plot_files_output = 1 | ||
| amr.plot_files_output = 0 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why disable plotfiles? |
||
|
|
||
| # Whether or not to output checkpoints | ||
| amr.checkpoint_files_output = 1 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to put in the date, git will record that