Skip to content

Make VODE_MAXORD a runtime parameter #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
psharda wants to merge 4 commits into
base: development
Choose a base branch
from
Draft

Make VODE_MAXORD a runtime parameter #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1a0819
Add VODE_MAXORD as a runtime param
psharda Aug 27, 2024
fb7f74a
access VODE_MAXORD using integrator namespace
psharda Aug 27, 2024
9175c98
VODE_LMAX cannot be a constexpr anymore
psharda Aug 27, 2024
6405ec8
Merge branch 'development' into vode_maxord
psharda Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions integration/VODE/_parameters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,8 @@
# for the step rejection logic on mass fractions, we only consider
# species that are > X_reject_buffer * atol_spec
X_reject_buffer real 1.0

# set the max integration order for VODE
# For the backward differentiation formula (BDF) integration
# the maximum order should be no greater than 5.
VODE_MAXORD int 5
5 changes: 1 addition & 4 deletions integration/VODE/vode_type.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ constexpr amrex::Real HMIN = 0.0_rt;
constexpr amrex::Real vode_increase_change_factor = 4.0_rt;
constexpr amrex::Real vode_decrease_change_factor = 0.25_rt;

// For the backward differentiation formula (BDF) integration
// the maximum order should be no greater than 5.
constexpr int VODE_MAXORD = 5;
constexpr int VODE_LMAX = VODE_MAXORD + 1;
int VODE_LMAX = integrator_rp::VODE_MAXORD + 1;

// How many timesteps should pass before refreshing the Jacobian
constexpr int max_steps_between_jacobian_evals = 50;
Expand Down