start of support for C++20

.clang-tidy

@@ -21,6 +21,7 @@ Checks: >
        -misc-use-internal-linkage,
      modernize-*,
        -modernize-avoid-c-arrays,
+       -modernize-use-designated-initializers,
        -modernize-use-trailing-return-type,
      performance-*,
        -performance-avoid-endl,

.github/workflows/castro-development.yml

@@ -47,7 +47,7 @@ jobs:
         export MICROPHYSICS_HOME=${PWD}
 
         cd Castro/Exec/science/flame_wave/
-        make -j 4 CCACHE=ccache USE_MPI=FALSE
+        make -j 4 CXXSTD=c++20 CCACHE=ccache USE_MPI=FALSE
 
         ccache -s
         du -hs ~/.cache/ccache
@@ -64,7 +64,7 @@ jobs:
         export MICROPHYSICS_HOME=${PWD}
 
         cd Castro/Exec/science/subchandra/
-        make -j 4 CCACHE=ccache USE_MPI=FALSE NETWORK_DIR=he-burn/he-burn-19am
+        make -j 4 CXXSTD=c++20 CCACHE=ccache USE_MPI=FALSE NETWORK_DIR=he-burn/he-burn-19am
 
         ccache -s
         du -hs ~/.cache/ccache

.github/workflows/castro.yml

@@ -51,7 +51,7 @@ jobs:
         export MICROPHYSICS_HOME=${PWD}
 
         cd Castro/Exec/science/flame_wave/
-        make -j 4 CCACHE=ccache USE_MPI=FALSE
+        make -j 4 CXXSTD=c++20 CCACHE=ccache USE_MPI=FALSE
 
         ccache -s
         du -hs ~/.cache/ccache
@@ -68,7 +68,7 @@ jobs:
         export MICROPHYSICS_HOME=${PWD}
 
         cd Castro/Exec/science/subchandra/
-        make -j 4 CCACHE=ccache USE_MPI=FALSE NETWORK_DIR=he-burn/he-burn-19am
+        make -j 4 CXXSTD=c++20 CCACHE=ccache USE_MPI=FALSE NETWORK_DIR=he-burn/he-burn-19am
 
         ccache -s
         du -hs ~/.cache/ccache

.github/workflows/cuda.yml

@@ -8,7 +8,7 @@ concurrency:
 
 jobs:
   cuda-compile:
-    name: CUDA@11.7 GCC
+    name: CUDA@12.9 GCC
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v6
@@ -26,7 +26,7 @@ jobs:
           cd ../..
 
       - name: Dependencies
-        run: .github/workflows/dependencies/dependencies_nvcc.sh 11.7
+        run: .github/workflows/dependencies/dependencies_nvcc.sh 12.9
 
       - name: compile test_react (aprox13)
         run: |

Docs/source/getting_started.rst

@@ -14,7 +14,7 @@ Microphysics requires
 
 optional dependencies are:
 
-* CUDA (≥ 11)
+* CUDA (≥ 12)
 * ROCm (≥ 6.3.1 --- earlier versions have register allocation bugs)
 
 Usage Modes

EOS/breakout/actual_eos.H

@@ -67,14 +67,14 @@ void actual_eos (I input, T& state)
         // dens, temp and xmass are inputs
         amrex::Real cv = R / (state.mu * (gamma_const - 1.0_rt));
         amrex::Real e = cv * state.T;
-        if constexpr (has_energy<T>::value) {
+        if constexpr (has_energy<T>) {
             state.cv = cv;
             state.e = e;
         }
-        if constexpr (has_pressure<T>::value) {
+        if constexpr (has_pressure<T>) {
             state.p = (gamma_const - 1.0_rt) * state.rho * e;
         }
-        if constexpr (has_pressure<T>::value && has_energy<T>::value) {
+        if constexpr (has_pressure<T> && has_energy<T>) {
             state.gam1 = gamma_const;
         }
 
@@ -102,10 +102,10 @@ void actual_eos (I input, T& state)
     {
         // dens, pres, and xmass are inputs
 
-        if constexpr (has_pressure<T>::value) {
+        if constexpr (has_pressure<T>) {
             amrex::Real poverrho = state.p / state.rho;
             state.T = poverrho * state.mu * (1.0_rt / R);
-            if constexpr (has_energy<T>::value) {
+            if constexpr (has_energy<T>) {
                 state.e = poverrho * (1.0_rt / (gamma_const - 1.0_rt));
                 state.gam1 = gamma_const;
             }
@@ -117,11 +117,11 @@ void actual_eos (I input, T& state)
     {
         // dens, energy, and xmass are inputs
 
-        if constexpr (has_energy<T>::value) {
+        if constexpr (has_energy<T>) {
             amrex::Real poverrho = (gamma_const - 1.0_rt) * state.e;
             state.T = poverrho * state.mu * (1.0_rt / R);
 
-            if constexpr (has_pressure<T>::value) {
+            if constexpr (has_pressure<T>) {
                 state.p = poverrho * state.rho;
                 state.gam1 = gamma_const;
 
@@ -135,7 +135,7 @@ void actual_eos (I input, T& state)
 
         // Try to avoid the expensive log function.  Since we don't need entropy
         // in hydro solver, set it to an invalid but "nice" value for the plotfile.
-        if constexpr (has_entropy<T>::value) {
+        if constexpr (has_entropy<T>) {
             state.s = 1.0_rt;
         }
 

EOS/eos_composition.H

@@ -85,7 +85,7 @@ eos_xderivs_t composition_derivatives (const T& state)
   eos_xderivs_t state_xderivs;
 
   for (int n = 0; n < NumSpec; n++) {
-      if constexpr (has_dpdA<T>::value && has_dpdZ<T>::value) {
+      if constexpr (has_dpdA<T> && has_dpdZ<T>) {
           state_xderivs.dpdX[n] =
               state.dpdA * (state.abar * aion_inv[n]) * (aion[n] - state.abar) +
               state.dpdZ * (state.abar * aion_inv[n]) * (zion[n] - state.zbar);
@@ -94,7 +94,7 @@ eos_xderivs_t composition_derivatives (const T& state)
           state_xderivs.dpdX[n] = 0.0_rt;
       }
 
-      if constexpr (has_dedA<T>::value && has_dedZ<T>::value) {
+      if constexpr (has_dedA<T> && has_dedZ<T>) {
           state_xderivs.dedX[n] =
               state.dedA * (state.abar * aion_inv[n]) * (aion[n] - state.abar) +
               state.dedZ * (state.abar * aion_inv[n]) * (zion[n] - state.zbar);
@@ -103,7 +103,7 @@ eos_xderivs_t composition_derivatives (const T& state)
           state_xderivs.dedX[n] = 0.0_rt;
       }
 
-      if constexpr (has_pressure<T>::value) {
+      if constexpr (has_pressure<T>) {
           if (state.dpdr != 0.0) {
 
               state_xderivs.dhdX[n] = state_xderivs.dedX[n]

EOS/gamma_law/actual_eos.H

@@ -54,7 +54,7 @@ void actual_eos (I input, T& state)
     // Get the mass of a nucleon from m_u.
     const amrex::Real m_nucleon = C::m_u;
 
-    if constexpr (has_xn<T>::value) {
+    if constexpr (has_xn<T>) {
         if (eos_rp::eos_assume_neutral) {
             state.mu = state.abar;
         } else {
@@ -86,7 +86,7 @@ void actual_eos (I input, T& state)
         // Solve for the temperature:
         // h = e + p/rho = (p/rho)*[1 + 1/(gamma-1)] = (p/rho)*gamma/(gamma-1)
 
-          if constexpr (has_enthalpy<T>::value) {
+          if constexpr (has_enthalpy<T>) {
               state.T = (state.h * state.mu * m_nucleon / C::k_B)*(eos_rp::eos_gamma - 1.0)/eos_rp::eos_gamma;
           }
 
@@ -99,7 +99,7 @@ void actual_eos (I input, T& state)
           // Solve for the density:
           // p = rho k T / (mu m_nucleon)
 
-          if constexpr (has_pressure<T>::value) {
+          if constexpr (has_pressure<T>) {
               state.rho =  state.p * state.mu * m_nucleon / (C::k_B * state.T);
           }
 
@@ -112,7 +112,7 @@ void actual_eos (I input, T& state)
           // Solve for the temperature:
           // p = rho k T / (mu m_nucleon)
 
-          if constexpr (has_pressure<T>::value) {
+          if constexpr (has_pressure<T>) {
               state.T = state.p * state.mu * m_nucleon / (C::k_B * state.rho);
           }
 
@@ -125,7 +125,7 @@ void actual_eos (I input, T& state)
           // Solve for the temperature
           // e = k T / [(mu m_nucleon)*(gamma-1)]
 
-          if constexpr (has_energy<T>::value) {
+          if constexpr (has_energy<T>) {
               state.T = state.e * state.mu * m_nucleon * (eos_rp::eos_gamma - 1.0) / C::k_B;
           }
 
@@ -139,7 +139,7 @@ void actual_eos (I input, T& state)
           // Invert Sackur-Tetrode eqn (below) using
           // rho = p mu m_nucleon / (k T)
 
-          if constexpr (has_pressure<T>::value && has_entropy<T>::value) {
+          if constexpr (has_pressure<T> && has_entropy<T>) {
               state.T = std::pow(state.p, 2.0/5.0) *
                         std::pow(2.0 * M_PI * C::hbar * C::hbar / (state.mu * m_nucleon), 3.0/5.0) *
                         std::exp(2.0 * state.mu * m_nucleon * state.s / (5.0 * C::k_B) - 1.0) / C::k_B;
@@ -148,7 +148,7 @@ void actual_eos (I input, T& state)
           // Solve for the density
           // rho = p mu m_nucleon / (k T)
 
-          if constexpr (has_pressure<T>::value) {
+          if constexpr (has_pressure<T>) {
               state.rho = state.p * state.mu * m_nucleon / (C::k_B * state.T);
           }
 
@@ -160,7 +160,7 @@ void actual_eos (I input, T& state)
 
           // Solve for temperature and density
 
-          if constexpr (has_pressure<T>::value && has_enthalpy<T>::value) {
+          if constexpr (has_pressure<T> && has_enthalpy<T>) {
               state.rho = state.p / state.h * eos_rp::eos_gamma / (eos_rp::eos_gamma - 1.0);
               state.T = state.p * state.mu * m_nucleon / (C::k_B * state.rho);
           }
@@ -199,21 +199,21 @@ void actual_eos (I input, T& state)
     // specific internal energy using the gamma-law EOS relation.
     amrex::Real pressure = state.rho * state.T * C::k_B / (state.mu * m_nucleon);
     amrex::Real energy = pressure / (eos_rp::eos_gamma - 1.0) * rhoinv;
-    if constexpr (has_pressure<T>::value) {
+    if constexpr (has_pressure<T>) {
         state.p = pressure;
     }
-    if constexpr (has_energy<T>::value) {
+    if constexpr (has_energy<T>) {
         state.e = energy;
     }
 
     // enthalpy is h = e + p/rho
-    if constexpr (has_enthalpy<T>::value) {
+    if constexpr (has_enthalpy<T>) {
         state.h = energy + pressure * rhoinv;
     }
 
     // entropy (per gram) of an ideal monoatomic gas (the Sackur-Tetrode equation)
     // NOTE: this expression is only valid for gamma = 5/3.
-    if constexpr (has_entropy<T>::value) {
+    if constexpr (has_entropy<T>) {
         const amrex::Real fac = 1.0 / std::pow(2.0 * M_PI * C::hbar * C::hbar, 1.5);
 
         state.s = (C::k_B / (state.mu * m_nucleon)) *
@@ -222,39 +222,39 @@ void actual_eos (I input, T& state)
     }
 
     // Compute the thermodynamic derivatives and specific heats
-    if constexpr (has_pressure<T>::value) {
+    if constexpr (has_pressure<T>) {
         state.dpdT = state.p * Tinv;
         state.dpdr = state.p * rhoinv;
     }
-    if constexpr (has_energy<T>::value) {
+    if constexpr (has_energy<T>) {
         state.dedT = state.e * Tinv;
         state.dedr = 0.0;
     }
-    if constexpr (has_entropy<T>::value) {
+    if constexpr (has_entropy<T>) {
         state.dsdT = 1.5 * (C::k_B / (state.mu * m_nucleon)) * Tinv;
         state.dsdr = - (C::k_B / (state.mu * m_nucleon)) * rhoinv;
     }
-    if constexpr (has_enthalpy<T>::value) {
+    if constexpr (has_enthalpy<T>) {
         state.dhdT = state.dedT + state.dpdT * rhoinv;
         state.dhdr = 0.0;
     }
 
-    if constexpr (has_xne_xnp<T>::value) {
+    if constexpr (has_xne_xnp<T>) {
         state.xne = 0.0;
         state.xnp = 0.0;
     }
-    if constexpr (has_eta<T>::value) {
+    if constexpr (has_eta<T>) {
         state.eta = 0.0;
     }
-    if constexpr (has_pele_ppos<T>::value) {
+    if constexpr (has_pele_ppos<T>) {
         state.pele = 0.0;
         state.ppos = 0.0;
     }
 
-    if constexpr (has_energy<T>::value) {
+    if constexpr (has_energy<T>) {
         state.cv = state.dedT;
 
-        if constexpr (has_pressure<T>::value) {
+        if constexpr (has_pressure<T>) {
             state.cp = eos_rp::eos_gamma * state.cv;
 
             state.gam1 = eos_rp::eos_gamma;
@@ -264,31 +264,31 @@ void actual_eos (I input, T& state)
 
             // sound speed
             state.cs = std::sqrt(eos_rp::eos_gamma * state.p * rhoinv);
-            if constexpr (has_G<T>::value) {
+            if constexpr (has_G<T>) {
                 state.G = 0.5 * (1.0 + eos_rp::eos_gamma);
             }
         }
     }
 
-    if constexpr (has_dpdA<T>::value) {
+    if constexpr (has_dpdA<T>) {
         state.dpdA = - state.p * (1.0 / state.abar);
     }
-    if constexpr (has_dedA<T>::value) {
+    if constexpr (has_dedA<T>) {
         state.dedA = - state.e * (1.0 / state.abar);
     }
 
     if (eos_rp::eos_assume_neutral) {
-        if constexpr (has_dpdZ<T>::value) {
+        if constexpr (has_dpdZ<T>) {
             state.dpdZ = 0.0;
         }
-        if constexpr (has_dedZ<T>::value) {
+        if constexpr (has_dedZ<T>) {
             state.dedZ = 0.0;
         }
     } else {
-        if constexpr (has_dpdZ<T>::value) {
+        if constexpr (has_dpdZ<T>) {
             state.dpdZ = state.p * (1.0 / (1.0 + state.zbar));
         }
-        if constexpr (has_dedZ<T>::value) {
+        if constexpr (has_dedZ<T>) {
             state.dedZ = state.e * (1.0/(1.0 + state.zbar));
         }
     }