Fix: Names in PC::make_alike#4322
Merged
ax3l merged 1 commit intoAMReX-Codes:developmentfrom Feb 4, 2025
Merged
Conversation
1 task
0caf0ae to
dc68e02
Compare
WeiqunZhang
approved these changes
Feb 4, 2025
Member
Author
|
Wait, there is more to it. Have to also set the compile-time names. |
dc68e02 to
c1be6b8
Compare
The ParticleContainer's `make_alike` function forgot the names of the SoA components.
c1be6b8 to
22f2d43
Compare
Member
Author
|
Now it's complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ParticleContainer's
make_alikefunction must not forget the names of the SoA components. Currently, it creates a new container with the same components, but default names.Additional background
First seen in BLAST-WarpX/warpx#5481
Checklist
The proposed changes: