Skip to content

Copy comm flags in make_alike#4341

Merged
ax3l merged 1 commit intoAMReX-Codes:developmentfrom
atmyers:make_alike_comm_flags
Feb 21, 2025
Merged

Copy comm flags in make_alike#4341
ax3l merged 1 commit intoAMReX-Codes:developmentfrom
atmyers:make_alike_comm_flags

Conversation

@atmyers
Copy link
Copy Markdown
Member

@atmyers atmyers commented Feb 21, 2025

Need to make sure these are preserved (we use them as IO flags in WarpX)

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from ax3l February 21, 2025 22:43
@ax3l ax3l added the bug label Feb 21, 2025
Copy link
Copy Markdown
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch!

@ax3l ax3l enabled auto-merge (squash) February 21, 2025 22:46
@ax3l ax3l self-assigned this Feb 21, 2025
@ax3l ax3l merged commit 612e7e2 into AMReX-Codes:development Feb 21, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants