Force the alignment of SoA and AoS Particles

[WeiqunZhang]

This fixes build issues on 32-bit Linux. This should not affect 64 bits machines.

Fix #4371

[ax3l]

@WeiqunZhang I see still the same error with this patch in BLAST-ImpactX/impactx-wheels#3

[ax3l]

Oh, I think I tested the first version. Will restart with the latest changes now.

[ax3l]

Ok, improvement. Now only the legacy data type (AoS + SoA) has the same alignment issue, too, e.g., for amrex::Particle<2, 1> in void amrex::ParticleContainer_impl

    [ 60%] Building CXX object _deps/fetchedpyamrex-build/CMakeFiles/pyAMReX_3d.dir/src/Particle/ParticleContainer_FHDeX.cpp.o
    cd /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-build && /opt/rh/devtoolset-10/root/usr/bin/c++ -DAMREX_SPACEDIM=3 -DpyAMReX_3d_EXPORTS -I/project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src -I/usr/local/share/amrex/C_scripts -isystem /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include -isystem /opt/python/cp39-cp39/include/python3.9 -Wall -Wextra -Wpedantic -Wshadow -Woverloaded-virtual -Wunreachable-code -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -pthread -flto -fno-fat-lto-objects -MD -MT _deps/fetchedpyamrex-build/CMakeFiles/pyAMReX_3d.dir/src/Particle/ParticleContainer_FHDeX.cpp.o -MF CMakeFiles/pyAMReX_3d.dir/src/Particle/ParticleContainer_FHDeX.cpp.o.d -o CMakeFiles/pyAMReX_3d.dir/src/Particle/ParticleContainer_FHDeX.cpp.o -c /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer_FHDeX.cpp
    In file included from /usr/local/include/AMReX_ParticleContainer.H:1542,
                     from /usr/local/include/AMReX_Particles.H:5,
                     from /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.H:20,
                     from /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.cpp:6:
    /usr/local/include/AMReX_ParticleContainerI.H: In instantiation of ‘void amrex::ParticleContainer_impl<ParticleType, NArrayReal, NArrayInt, Allocator, CellAssignor>::Initialize() [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = amrex::PinnedArenaAllocator; T_CellAssignor = amrex::DefaultAssignor]’:
    /usr/local/include/AMReX_ParticleContainer.H:204:9:   required from ‘amrex::ParticleContainer_impl<ParticleType, NArrayReal, NArrayInt, Allocator, CellAssignor>::ParticleContainer_impl() [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = amrex::PinnedArenaAllocator; T_CellAssignor = amrex::DefaultAssignor]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/detail/init.h:76:12:   required from ‘Class* pybind11::detail::initimpl::construct_or_initialize(Args&& ...) [with Class = amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, amrex::PinnedArenaAllocator, amrex::DefaultAssignor>; Args = {}; typename std::enable_if<std::is_constructible<_Tp, _Args>::value, int>::type <anonymous> = 0]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/detail/init.h:208:70:   required from ‘static void pybind11::detail::initimpl::constructor<Args>::execute(Class&, const Extra& ...) [with Class = pybind11::class_<amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, amrex::PinnedArenaAllocator, amrex::DefaultAssignor> >; Extra = {}; typename std::enable_if<(! Class::has_alias), int>::type <anonymous> = 0; Args = {}]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/pybind11.h:1659:21:   required from ‘pybind11::class_<type_, options>& pybind11::class_<type_, options>::def(const pybind11::detail::initimpl::constructor<Args ...>&, const Extra& ...) [with Args = {}; Extra = {}; type_ = amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, amrex::PinnedArenaAllocator, amrex::DefaultAssignor>; options = {}]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.H:178:13:   required from ‘void make_ParticleContainer_and_Iterators(pybind11::module&, std::string) [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = amrex::PinnedArenaAllocator; pybind11::module = pybind11::module_; std::string = std::basic_string<char>]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.H:513:41:   required from ‘void make_ParticleContainer_and_Iterators(pybind11::module&) [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; pybind11::module = pybind11::module_]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.cpp:57:65:   required from here
    /usr/local/include/AMReX_ParticleContainerI.H:77:61: error: static assertion failed: sizeof ParticleType is not a multiple of sizeof RealType
       77 |         static_assert(sizeof(ParticleType)%sizeof(RealType) == 0,
          |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
    /usr/local/include/AMReX_ParticleContainerI.H: In instantiation of ‘void amrex::ParticleContainer_impl<ParticleType, NArrayReal, NArrayInt, Allocator, CellAssignor>::Initialize() [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = std::allocator; T_CellAssignor = amrex::DefaultAssignor]’:
    /usr/local/include/AMReX_ParticleContainer.H:204:9:   required from ‘amrex::ParticleContainer_impl<ParticleType, NArrayReal, NArrayInt, Allocator, CellAssignor>::ParticleContainer_impl() [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = std::allocator; T_CellAssignor = amrex::DefaultAssignor]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/detail/init.h:76:12:   required from ‘Class* pybind11::detail::initimpl::construct_or_initialize(Args&& ...) [with Class = amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, std::allocator, amrex::DefaultAssignor>; Args = {}; typename std::enable_if<std::is_constructible<_Tp, _Args>::value, int>::type <anonymous> = 0]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/detail/init.h:208:70:   required from ‘static void pybind11::detail::initimpl::constructor<Args>::execute(Class&, const Extra& ...) [with Class = pybind11::class_<amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, std::allocator, amrex::DefaultAssignor> >; Extra = {}; typename std::enable_if<(! Class::has_alias), int>::type <anonymous> = 0; Args = {}]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/pybind11.h:1659:21:   required from ‘pybind11::class_<type_, options>& pybind11::class_<type_, options>::def(const pybind11::detail::initimpl::constructor<Args ...>&, const Extra& ...) [with Args = {}; Extra = {}; type_ = amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, std::allocator, amrex::DefaultAssignor>; options = {}]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.H:178:13:   required from ‘void make_ParticleContainer_and_Iterators(pybind11::module&, std::string) [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = std::allocator; pybind11::module = pybind11::module_; std::string = std::basic_string<char>]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.H:531:37:   required from ‘void make_ParticleContainer_and_Iterators(pybind11::module&) [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; pybind11::module = pybind11::module_]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.cpp:57:65:   required from here
    /usr/local/include/AMReX_ParticleContainerI.H:77:61: error: static assertion failed: sizeof ParticleType is not a multiple of sizeof RealType
    /usr/local/include/AMReX_ParticleContainerI.H: In instantiation of ‘void amrex::ParticleContainer_impl<ParticleType, NArrayReal, NArrayInt, Allocator, CellAssignor>::Initialize() [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = amrex::ArenaAllocator; T_CellAssignor = amrex::DefaultAssignor]’:
    /usr/local/include/AMReX_ParticleContainer.H:204:9:   required from ‘amrex::ParticleContainer_impl<ParticleType, NArrayReal, NArrayInt, Allocator, CellAssignor>::ParticleContainer_impl() [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = amrex::ArenaAllocator; T_CellAssignor = amrex::DefaultAssignor]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/detail/init.h:76:12:   required from ‘Class* pybind11::detail::initimpl::construct_or_initialize(Args&& ...) [with Class = amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, amrex::ArenaAllocator, amrex::DefaultAssignor>; Args = {}; typename std::enable_if<std::is_constructible<_Tp, _Args>::value, int>::type <anonymous> = 0]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/detail/init.h:208:70:   required from ‘static void pybind11::detail::initimpl::constructor<Args>::execute(Class&, const Extra& ...) [with Class = pybind11::class_<amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, amrex::ArenaAllocator, amrex::DefaultAssignor> >; Extra = {}; typename std::enable_if<(! Class::has_alias), int>::type <anonymous> = 0; Args = {}]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpybind11-src/include/pybind11/pybind11.h:1659:21:   required from ‘pybind11::class_<type_, options>& pybind11::class_<type_, options>::def(const pybind11::detail::initimpl::constructor<Args ...>&, const Extra& ...) [with Args = {}; Extra = {}; type_ = amrex::ParticleContainer_impl<amrex::Particle<2, 1>, 3, 1, amrex::ArenaAllocator, amrex::DefaultAssignor>; options = {}]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.H:178:13:   required from ‘void make_ParticleContainer_and_Iterators(pybind11::module&, std::string) [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; Allocator = amrex::ArenaAllocator; pybind11::module = pybind11::module_; std::string = std::basic_string<char>]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.H:533:35:   required from ‘void make_ParticleContainer_and_Iterators(pybind11::module&) [with T_ParticleType = amrex::Particle<2, 1>; int T_NArrayReal = 3; int T_NArrayInt = 1; pybind11::module = pybind11::module_]’
    /project/build/temp.linux-i686-cpython-39/Release/_deps/fetchedpyamrex-src/src/Particle/ParticleContainer.cpp:57:65:   required from here
    /usr/local/include/AMReX_ParticleContainerI.H:77:61: error: static assertion failed: sizeof ParticleType is not a multiple of sizeof RealType

[ax3l]

Oh wait, that was patched here as well. So does not work just yet it seems.

[ax3l]

Added a CI runner that shows the issue (and fixed a few more musl issues in #4385 on the way).

Status is still:

/home/runner/work/amrex/amrex/Src/Particle/AMReX_ParticleContainerI.H:77:61: error: static assertion failed: sizeof ParticleType is not a multiple of sizeof RealType
   77 |         static_assert(sizeof(ParticleType)%sizeof(RealType) == 0,
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
/home/runner/work/amrex/amrex/Src/Particle/AMReX_ParticleContainerI.H:77:61: note: the comparison reduces to '(4 == 0)'

If you have more ideas, you can push them here and see if the AlpineLinux runner passes.

[WeiqunZhang]

There might be a compiler bug that does not treat multiple alignas statements correctly. It is supposed to use the strictest one, but it might be using the last one. If I only use one, the Particle CI tests pass.

[ax3l]

Yay, works for ImpactX 25.04+ now: BLAST-ImpactX/impactx-wheels#6 🎉