Skip to content

add dummy argument to CreateLike for particlecontainers to match the … #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

add dummy argument to CreateLike for particlecontainers to match the … #4657

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ab833
add dummy argument to CreateLike for particlecontainers to match the …
Sep 16, 2025
c073212
comment out variable name to avoid unused parameter warnings
Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Src/Base/AMReX_IntegratorBase.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ template<class T>
struct IntegratorOps<T, std::enable_if_t<std::is_base_of_v<amrex::ParticleContainerBase, T> > >
{

static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other)
static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool dummy = false)
Copy link
Member

@atmyers atmyers Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

Suggested change
static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool dummy = false)
static void CreateLike (amrex::Vector<std::unique_ptr<T> >& V, const T& Other, bool /*dummy*/ = false)

to avoid unused parameter warnings.

{
// Emplace a new T in V with the same size as Other and get a reference
V.emplace_back(std::make_unique<T>(Other.Geom(0), Other.ParticleDistributionMap(0), Other.ParticleBoxArray(0)));
Expand Down
Loading