Skip to content

Mention that particles with invalid ids are removed by default and be explicit about allowed ranges #4807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Mention that particles with invalid ids are removed by default and be explicit about allowed ranges #4807

wants to merge 3 commits into from

Conversation

@atmyers
Copy link
Member

@atmyers atmyers commented Nov 19, 2025 •
edited
Loading

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

WeiqunZhang
WeiqunZhang reviewed Nov 19, 2025
View reviewed changes
Docs/sphinx_documentation/source/Particle.rst Outdated
simulation. During :cpp:`Redistribute()`, particles with
invalid ids are removed from the simulation by default, although this behavior is customizable. Particles
with invalid ids are also not written out during plotfile writes or checkpoint / restart operations.
The allowed values for :cpp:`p.id()` are 0 to 2**39, and the allowed values for :cpp:`p.cpu()` are
Copy link
Member

@WeiqunZhang WeiqunZhang Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it include 2**39?

atmyers
atmyers commented Nov 19, 2025
View reviewed changes
atmyers
atmyers commented Nov 19, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang left review comments

@asalmgren asalmgren Awaiting requested review from asalmgren

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atmyers @WeiqunZhang