FFT: Fix one-d mode in 2D & 3D builds#5225
Merged
WeiqunZhang merged 3 commits intoAMReX-Codes:developmentfrom Mar 25, 2026
Merged
FFT: Fix one-d mode in 2D & 3D builds#5225WeiqunZhang merged 3 commits intoAMReX-Codes:developmentfrom
WeiqunZhang merged 3 commits intoAMReX-Codes:developmentfrom
Conversation
* Previously it did not handle the single process case correctly. * Fix scaling factor for the one-mode in 2d builds. * Add tests.
Member
Author
|
/run-hpsf-gitlab-ci |
|
GitLab CI has started at https://gitlab.spack.io/amrex/amrex/-/pipelines/1491596. |
|
GitLab CI 1491596 finished with status: failed. See details at https://gitlab.spack.io/amrex/amrex/-/pipelines/1491596. |
Member
Author
|
The GitLab CI failure was a machine issue. |
ajnonaka
approved these changes
Mar 25, 2026
Contributor
ajnonaka
left a comment
ajnonaka
left a comment
There was a problem hiding this comment.
DIM=2 builds work with oned_mode (serial and parallel)
DIM=3 builds work with twod_mode (serial and parallel)
WeiqunZhang
changed the title
Member
Author
|
/run-hpsf-gitlab-ci |
|
GitLab CI has started at https://gitlab.spack.io/amrex/amrex/-/pipelines/1492836. |
|
GitLab CI 1492836 finished with status: failed. See details at https://gitlab.spack.io/amrex/amrex/-/pipelines/1492836. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it did not handle the single process case correctly.
Fix twod_mode=false && oned_mode=true in 3D. Previously, we only support twod_mode=true && oned_mode=true.
Fix scaling factor for the one-mode.
Add tests.