Skip to content

SUNDIALS: Use ParallelContext's communicator #5237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WeiqunZhang wants to merge 1 commit into
base: development
Choose a base branch
from
Open

SUNDIALS: Use ParallelContext's communicator #5237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Src/Extern/SUNDIALS/AMReX_NVector_MultiFab.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
Donald Willcox (dewillcox@lbl.gov)
----------------------------------------------------------------------------*/
#include "AMReX_NVector_MultiFab.H"
#include <AMReX_ParallelContext.H>
#include <AMReX_ParallelReduce.H>
#include <type_traits>

namespace amrex::sundials {
Expand Down Expand Up @@ -465,7 +467,7 @@ amrex::Real NormHelper_NVector_MultiFab(N_Vector a_x, N_Vector a_w, N_Vector id,
[=] AMREX_GPU_HOST_DEVICE (amrex::Real x, amrex::Real y) -> amrex::Real { return x*x*y*y; },
numcomp, nghost, local);
}
ParallelDescriptor::ReduceRealSum(sum);
ParallelAllReduce::Sum(sum, ParallelContext::CommunicatorSub());

return rms ? std::sqrt(sum/Real(N)) : std::sqrt(sum);
}
Expand Down Expand Up @@ -593,7 +595,7 @@ int N_VConstrMask_MultiFab(N_Vector a_a, N_Vector a_x, N_Vector a_m)

temp = mf_m->norm1();
/* Return false if any constraint was violated */
amrex::ParallelDescriptor::ReduceRealMax(temp);
ParallelAllReduce::Max(temp, ParallelContext::CommunicatorSub());

return (temp == amrex::Real(1.0)) ? SUNFALSE : SUNTRUE;
}
Expand Down Expand Up @@ -632,7 +634,7 @@ amrex::Real N_VMinQuotient_MultiFab(N_Vector a_num, N_Vector a_denom)
return min_loc;
});

amrex::ParallelDescriptor::ReduceRealMin(min);
ParallelAllReduce::Min(min, ParallelContext::CommunicatorSub());

return min;
}
Expand Down
Loading