Fix insufficient buffer when projecting grids during regrid#5267
Draft
WeiqunZhang wants to merge 1 commit intoAMReX-Codes:developmentfrom
Draft
Fix insufficient buffer when projecting grids during regrid#5267WeiqunZhang wants to merge 1 commit intoAMReX-Codes:developmentfrom
WeiqunZhang wants to merge 1 commit intoAMReX-Codes:developmentfrom
Conversation
AmrMesh::MakeNewGrids now grows TagBoxes enough to keep intermediate levels properly nested after projecting fine grids downward, preventing the under-tagging that previously led to improperly nested grids.
Contributor
|
Although we currently regrid very frequently, this is something we also might run into with our typical number of levels. Could a test be added for this? |
Member
Author
|
Yesterday, I had Codex to try to reproduce the issue, but it failed. It also failed to figured out the issue. But now I think I understand the issue and I should be able to come up with a small test to reproduce the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AmrMesh::MakeNewGrids now grows TagBoxes enough to keep intermediate levels properly nested after projecting fine grids downward, preventing the under-tagging that previously led to improperly nested grids.