Robustify IntVect and RealVect read#5310
Merged
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom Apr 14, 2026
Merged
Robustify IntVect and RealVect read#5310WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
WeiqunZhang merged 2 commits intoAMReX-Codes:developmentfrom
Conversation
asalmgren
approved these changes
Apr 11, 2026
WeiqunZhang
force-pushed
the
realvect_read
branch
2 times, most recently
from
815c158 to
4f7ec1b
Compare
In the old approach, inputs like `(3,2` without closing `)` are silently accepted. Maintain backward compatibility. Consolidate IntVect and RealVector I/O.
WeiqunZhang
force-pushed
the
realvect_read
branch
from
4f7ec1b to
b3d490d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the old approach, inputs like
(3,2without closing)are silently accepted.Consolidate IntVect and RealVec I/O.