This repository was archived by the owner on Jan 10, 2024. It is now read-only.
Change wall BCs from reflect_even/odd to extrap/ext_dir. Note this #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also changes species_bc for isothermal walls to ext_dir to align with PeleLMeX.
Contributor
Author
|
As noted for PeleLMeX, I am not certain if PeleLM(eX) provides a default for ext_dir BCs. IAMR does so, but it is through NS, so PeleLM wouldn't inherit it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also changes species_bc for isothermal walls to ext_dir to align with PeleLMeX.